Skip Menu |

This queue is for tickets about the BSD-Resource CPAN distribution.

Report information
The Basics
Id: 86857
Status: resolved
Priority: 0/
Queue: BSD-Resource
People
Owner: Nobody in particular
Requestors: hsk [...] fli-leibniz.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.2906
Fixed in: 1.2907
Attachments
make_test.out
patch

History Show all quoted text
  Thu Jul 11 10:42:13 2013 hsk [...] fli-leibniz.de - Ticket created
Subject: t/setrlimit.t failure
test-suite for bsd-resource-1.2906 on opensuse 12.2 / perl 5.18.0 fails for me; error message from setrlimit.t: "setrlimit(RLIMIT_STACK, 6291456, 0) failed: Invalid argument" shouldn't the rounding-down thing be done as follows ? --- t/setrlimit.t__ 2013-07-07 16:39:30.000000000 +0200 +++ t/setrlimit.t 2013-07-11 16:23:29.896165919 +0200 @@ -49,7 +49,7 @@ my $n = 4096; print "# Rounding down to $n byte boundary\n"; ($try_soft, $try_hard) = - map { int($_ / $n) * $n } ($try_soft, $try_hard); + map { ($_ == RLIM_INFINITY) ? RLIM_INFINITY : (int($_ / $n) * $n) } ($try_soft, $try_hard); } print "# try_soft = $try_soft, try_hard = $try_hard\n"; my $success = setrlimit($lim, $try_soft, $try_hard);
  Thu Jul 11 11:01:04 2013 JHI [...] cpan.org - Correspondence added
Something else is going on because if you look at just a few lines earlier we should not even get to the rounding part if we have RLIM_INFINITY. Could you please debug some more?
  Thu Jul 11 11:01:04 2013 The RT System itself - Status changed from 'new' to 'open'
  Thu Jul 11 11:08:38 2013 paul [...] city-fan.org - Correspondence added
From: paul [...] city-fan.org
On Thu Jul 11 11:01:04 2013, JHI wrote: Show quoted text
> Something else is going on because if you look at just a few lines > earlier we should not even get to the rounding part if we have > RLIM_INFINITY. Could you please debug some more?
The problem occurs when the hard limit is RLIM_INFINITY and the soft limit isn't. Only the soft limit is checked. I came up with the same fix myself.
  Thu Jul 11 11:13:08 2013 JHI [...] cpan.org - Correspondence added
On Thu Jul 11 11:08:38 2013, paul@city-fan.org wrote: Show quoted text
> On Thu Jul 11 11:01:04 2013, JHI wrote:
> > Something else is going on because if you look at just a few lines > > earlier we should not even get to the rounding part if we have > > RLIM_INFINITY. Could you please debug some more?
> > The problem occurs when the hard limit is RLIM_INFINITY and the soft > limit isn't. Only the soft limit is checked. I came up with the same > fix myself.
Ah, indeed. Thanks for the fix. I'll try to roll out a new version soon. In the meanwhile, I'll delete the 1.2906 since it has no benefits to anything else than cygwin.
  Thu Jul 11 11:13:43 2013 hsk [...] fli-leibniz.de - Correspondence added
From: hsk [...] fli-leibniz.de
On Thu Jul 11 11:01:04 2013, JHI wrote: Show quoted text
> Something else is going on because if you look at just a few lines > earlier we should not even get to the rounding part if we have > RLIM_INFINITY. Could you please debug some more? >
but you only look at $try_soft... output of "make test TEST_VERBOSE=1 TEST_FILES=t/setrlimit.t" see attachment
Subject: make_test.out
Download make_test.out
application/octet-stream 2.8k

Message body not shown because it is not plain text.

  Thu Jul 11 13:11:32 2013 JHI [...] cpan.org - Correspondence added
On Thu Jul 11 11:13:43 2013, hsk@fli-leibniz.de wrote: Show quoted text
> On Thu Jul 11 11:01:04 2013, JHI wrote:
> > Something else is going on because if you look at just a few lines > > earlier we should not even get to the rounding part if we have > > RLIM_INFINITY. Could you please debug some more? > >
> > but you only look at $try_soft... > > output of "make test TEST_VERBOSE=1 TEST_FILES=t/setrlimit.t" see attachment
Actually, could you please try the attached patch *instead* of the suggested patch. I think I now remember why the skipping: if the limit is infinity, it is too messy to try to test it. So the attached patch skips the test if either limit is infinity.
Subject: patch
Download patch
application/octet-stream 756b

Message body not shown because it is not plain text.

  Thu Jul 11 13:12:05 2013 JHI [...] cpan.org - Correspondence added
On Thu Jul 11 10:42:13 2013, hsk@fli-leibniz.de wrote: Show quoted text
> test-suite for bsd-resource-1.2906 on opensuse 12.2 / perl 5.18.0 > fails for me; error message from setrlimit.t: > "setrlimit(RLIMIT_STACK, 6291456, 0) failed: Invalid argument" > > shouldn't the rounding-down thing be done as follows ? > > --- t/setrlimit.t__ 2013-07-07 16:39:30.000000000 +0200 > +++ t/setrlimit.t 2013-07-11 16:23:29.896165919 +0200 > @@ -49,7 +49,7 @@ > my $n = 4096; > print "# Rounding down to $n byte boundary\n"; > ($try_soft, $try_hard) = > - map { int($_ / $n) * $n } ($try_soft, $try_hard); > + map { ($_ == RLIM_INFINITY) ? RLIM_INFINITY : (int($_ / > $n) * $n) } ($try_soft, $try_hard); > } > print "# try_soft = $try_soft, try_hard = $try_hard\n"; > my $success = setrlimit($lim, $try_soft, $try_hard);
Similarly, please try the patch I just posted instead.
  Fri Jul 12 14:20:37 2013 JHI [...] cpan.org - Correspondence added
Ping?
  Mon Jul 15 02:16:18 2013 hsk [...] fli-leibniz.de - Correspondence added
From: hsk [...] fli-leibniz.de
On Fri Jul 12 14:20:37 2013, JHI wrote: Show quoted text
> Ping?
ahh - sorry - thanks, your patch is working for me, i.e, now no failures in test suite
  Mon Jul 15 07:44:09 2013 JHI [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Jul 15 07:44:09 2013 JHI [...] cpan.org - Fixed in 1.2907 added