Bug #86585 for IO-Socket-INET6: Missing semicolon on end of line

Sun Jun 30 13:08:19 2013 tony [...] metracom.com - Ticket created

Subject:	Missing semicolon on end of line
Date:	Sun, 30 Jun 2013 10:08:05 -0700
To:	bug-IO-Socket-INET6 [...] rt.cpan.org
From:	Tony <tony [...] metracom.com>

use Socket6 ( qw(AI_PASSIVE inet_ntop inet_pton getaddrinfo sockaddr_in6 unpack_sockaddr_in6_all pack_sockaddr_in6_all); <<<<< here );

Mon Jul 01 03:45:20 2013 SHLOMIF [...] cpan.org - Correspondence added

Hi Tony, On Sun Jun 30 13:08:19 2013, tony@metracom.com wrote: Show quoted text

> use Socket6 ( > qw(AI_PASSIVE inet_ntop inet_pton getaddrinfo > sockaddr_in6 unpack_sockaddr_in6_all pack_sockaddr_in6_all); <<<<< here > );

No, there is no missing semicolon there, because this is the end of the qw( ... ) inside the wrapping ( ... ), after which there *is* a semicolon. The file compiles and runs and tests fine: http://www.cpantesters.org/distro/I/IO-Socket-INET6.html#IO-Socket-INET6-2.71 Now my question to you is what made you think there is a missing semicolon and made you report it? Regards, -- Shlomi Fish

Mon Jul 01 03:45:21 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 01 11:40:11 2013 tony [...] metracom.com - Correspondence added

Subject:	Re: [rt.cpan.org #86585] Missing semicolon on end of line
Date:	Mon, 01 Jul 2013 08:39:48 -0700
To:	bug-IO-Socket-INET6 [...] rt.cpan.org
From:	tony [...] metracom.com (Tony)

"Shlomi Fish via RT" <bug-IO-Socket-INET6@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=86585 > > > Hi Tony, > > On Sun Jun 30 13:08:19 2013, tony@metracom.com wrote:

> > use Socket6 ( > > qw(AI_PASSIVE inet_ntop inet_pton getaddrinfo > > sockaddr_in6 unpack_sockaddr_in6_all pack_sockaddr_in6_all); <<<<< here > > );

> > No, there is no missing semicolon there, because this is the end of the qw( ... ) inside the wrapping ( ... ), after which there *is* a semicolon. The file compiles and runs and tests fine: > > http://www.cpantesters.org/distro/I/IO-Socket-INET6.html#IO-Socket-INET6-2.71 > > Now my question to you is what made you think there is a missing semicolon and made you report it? > > Regards, > > -- Shlomi Fish

A cronjob on my Linux mail server updates my spamassassin rule sets called "sa-update" the INET6.pm module was giving me an error on that line. I noticed that there was no simicolon on the end of the line so I added it. Now the 'sa-update" process runs without errors now. Thanks for taking a look at this. Tony

Thu Aug 01 10:09:51 2013 SHLOMIF [...] cpan.org - Correspondence added

Hello, Tony, sorry for the late response - it has been my fault. On Mon Jul 01 11:40:11 2013, tony@metracom.com wrote: Show quoted text

> "Shlomi Fish via RT" <bug-IO-Socket-INET6@rt.cpan.org> wrote: >

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=86585 > > > > > Hi Tony, > > > > On Sun Jun 30 13:08:19 2013, tony@metracom.com wrote:

> > > use Socket6 ( > > > qw(AI_PASSIVE inet_ntop inet_pton getaddrinfo > > > sockaddr_in6 unpack_sockaddr_in6_all pack_sockaddr_in6_all); > > > <<<<< here > > > );

> > > > No, there is no missing semicolon there, because this is the end of > > the qw( ... ) inside the wrapping ( ... ), after which there *is* a > > semicolon. The file compiles and runs and tests fine: > > > > http://www.cpantesters.org/distro/I/IO-Socket-INET6.html#IO-Socket- > > INET6-2.71 > > > > Now my question to you is what made you think there is a missing > > semicolon and made you report it? > > > > Regards, > > > > -- Shlomi Fish

> > A cronjob on my Linux mail server updates my spamassassin rule sets > called "sa-update" the INET6.pm module was giving me an error on that > line. I noticed that there was no simicolon on the end of the line so > I added it. Now the 'sa-update" process runs without errors now. >

Well, there shouldn't be a semicolon on that line - only no the next line (because it is «( qw( … ) )». If it requires this semicolon, then your perl is broken (although it seems like an unlikely bug). Can you investigate why that is the case? Do you still have the semicolon after the wrapping parentheses? Show quoted text

> Thanks for taking a look at this.

You're welcome. Regards, -- Shlomi Fish Show quoted text

> > Tony

Thu Oct 30 13:01:09 2014 Mark.Martinec [...] ijs.si - Correspondence added

From:

Mark.Martinec [...] ijs.si

Don't know about that semicolon, but the nested list is certainly redundant: the qw already produces a list. Should be: use Socket qw( AF_INET6 PF_INET6 SOCK_RAW SOCK_STREAM INADDR_ANY SOCK_DGRAM AF_INET SO_REUSEADDR SO_REUSEPORT AF_UNSPEC SO_BROADCAST sockaddr_in ); # IO::Socket and Socket already import stuff here - possibly AF_INET6 # and PF_INET6 so selectively import things from Socket6. use Socket6 qw( AI_PASSIVE getaddrinfo sockaddr_in6 unpack_sockaddr_in6_all pack_sockaddr_in6_all in6addr_any );

Fri Oct 31 04:22:54 2014 SHLOMIF [...] cpan.org - Correspondence added

Hi, On Thu Oct 30 13:01:09 2014, Mark.Martinec@ijs.si wrote: Show quoted text

> Don't know about that semicolon, but the nested list is certainly > redundant: the qw already produces a list.

It doesn't hurt much. Regards, -- Shlomi Fish

Fri Oct 31 04:24:22 2014 SHLOMIF [...] cpan.org - Correspondence added

I'm closing this bug since it seems invalid and I didn't get a response in over a year.

Fri Oct 31 04:24:22 2014 SHLOMIF [...] cpan.org - Status changed from 'open' to 'rejected'