| CC: | jkeenan [...] cpan.org, steve [...] fisharerojo.org |
| Subject: | [RT #37433] ExtUtils::MakeMaker: recognize OTHERLDFLAGS |
The following report and patch were originally filed in the Perl 5 bug queue in October 2005. They were reviewed there. The reviewer expressed concerns and indicated that a bug report would be filed in ExtUtils-MakeMaker's own queue here on rt.cpan.org.
However, I can find no evidence that the report was transferred here. ack-ing through the EU-MM source code shipped with 5.18.0 suggests that the patch has not been applied.
So, for the sake of completeness, I'm passing this report and one the reviewer's comment to you. I myself take no position on the patch. Thank you very much. -- jkeenan
##########
Overriding CCFLAGS and OTHERLDFLAGS from command line can be very useful
while testing and profiling XS code - i.e. see:
http://search.cpan.org/~pjcj/Devel-Cover-0.55/gcov2perl
These patches add OTHERLDFLAGS to @attrib_help and extend dynamic_lib():
--- MakeMaker.pm.orig 2005-10-14 15:37:07.907399600 +0400
+++ MakeMaker.pm 2005-10-14 15:37:09.969886400 +0400
@@ -229,6 +229,7 @@
INC INCLUDE_EXT LDFROM LIB LIBPERL_A LIBS
LINKTYPE MAKEAPERL MAKEFILE MAKEFILE_OLD MAN1PODS MAN3PODS MAP_TARGET
MYEXTLIB NAME NEEDS_LINKING NOECHO NO_META NORECURS NO_VC OBJECT
OPTIMIZE
+ OTHERLDFLAGS
PERL_MALLOC_OK PERL PERLMAINCC PERLRUN PERLRUNINST PERL_CORE
PERL_SRC PERM_RW PERM_RWX
PL_FILES PM PM_FILTER PMLIBDIRS POLLUTE PPM_INSTALL_EXEC
--- MM_Unix.pm.orig 2005-10-14 15:50:09.277398800 +0400
+++ MM_Unix.pm 2005-10-14 15:50:25.824167900 +0400
@@ -889,7 +889,7 @@
return '' unless $self->has_link_code;
- my($otherldflags) = $attribs{OTHERLDFLAGS} || "";
+ my($otherldflags) = $attribs{OTHERLDFLAGS} || $self->{OTHERLDFLAGS}
|| "";
my($inst_dynamic_dep) = $attribs{INST_DYNAMIC_DEP} || "";
my($armaybe) = $attribs{ARMAYBE} || $self->{ARMAYBE} || ":";
my($ldfrom) = '$(LDFROM)';
--
Sergey Skvortsov
mailto: skv@protey.ru
#########
On Thu Nov 10 19:10:15 2005, stmpeters wrote:
I am concerned about this patch. Code similar to what is in MM_Unix.pm is in other ExtUtils::MM* files. So, rather than accidentially breaking ExtUtils::MakeMaker, I'm going to pass this patch off to the rt.cpan.org queue for ExtUtils::MakeMaker.
##########