Bug #86551 for Module-Build-Tiny: Should use man1ext and man3ext

Fri Jun 28 12:51:35 2013 gregoa [...] cpan.org - Ticket created

Subject:

Should use man1ext and man3ext

Currently M::B::T hardcodes sections 1/3 for manpages; it would be better to read man{1,3}ext from %Config. (Noticed because we have 1p and 3pm in Debian for not-in-core manpages). Cheers, gregor

Fri Jun 28 14:15:46 2013 fawaka [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #86551] Should use man1ext and man3ext
Date:	Fri, 28 Jun 2013 20:15:11 +0200
To:	bug-Module-Build-Tiny [...] rt.cpan.org
From:	Leon Timmermans <fawaka [...] gmail.com>

On Fri, Jun 28, 2013 at 6:51 PM, gregor herrmann via RT <bug-Module-Build-Tiny@rt.cpan.org> wrote: Show quoted text

> Currently M::B::T hardcodes sections 1/3 for manpages; it would be better to read man{1,3}ext from %Config. > > (Noticed because we have 1p and 3pm in Debian for not-in-core manpages).

This bug was fixed in ExtUtils::Helpers 0.021, released on May 6th. Upgrading that should fix this issue. Leon

Fri Jun 28 14:15:46 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Jun 28 14:55:14 2013 LEONT [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jun 28 15:05:56 2013 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #86551] Should use man1ext and man3ext
Date:	Fri, 28 Jun 2013 21:05:35 +0200
To:	Leon Timmermans via RT <bug-Module-Build-Tiny [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Fri, 28 Jun 2013 14:15:46 -0400, Leon Timmermans via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=86551 >

Show quoted text

> > Currently M::B::T hardcodes sections 1/3 for manpages; it would be better to read man{1,3}ext from %Config. > > (Noticed because we have 1p and 3pm in Debian for not-in-core manpages).

> This bug was fixed in ExtUtils::Helpers 0.021, released on May 6th.

That's what I've used. Show quoted text

> Upgrading that should fix this issue.

Sorry, it doesn't :) And I can't imagine how ExtUtils::Helpers should change the hardcoded values in lib/Module/Build/Tiny.pm: manify($_, catfile('blib', 'bindoc', man1_pagename($_)), 1, \%opt) for keys %scripts; manify($_, catfile('blib', 'libdoc', man3_pagename($_)), 3, \%opt) for keys %modules; Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Beatles

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Fri Jun 28 15:15:35 2013 fawaka [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #86551] Should use man1ext and man3ext
Date:	Fri, 28 Jun 2013 21:15:04 +0200
To:	bug-Module-Build-Tiny [...] rt.cpan.org
From:	Leon Timmermans <fawaka [...] gmail.com>

On Fri, Jun 28, 2013 at 9:05 PM, gregor herrmann via RT <bug-Module-Build-Tiny@rt.cpan.org> wrote: Show quoted text

> Sorry, it doesn't :) > > And I can't imagine how ExtUtils::Helpers should change the hardcoded > values in lib/Module/Build/Tiny.pm: > > manify($_, catfile('blib', 'bindoc', man1_pagename($_)), 1, \%opt) for keys %scripts; > manify($_, catfile('blib', 'libdoc', man3_pagename($_)), 3, \%opt) for keys %modules;

I see, then I completely misunderstood what you meant. Module::Build::Tiny is following Module::Build here, but Debian uses a patched Module::Build. Probably Module::Build needs a similar patch. Leon

Fri Jun 28 15:17:43 2013 LEONT [...] cpan.org - Status changed from 'resolved' to 'open'

Fri Jun 28 16:54:01 2013 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #86551] Should use man1ext and man3ext
Date:	Fri, 28 Jun 2013 22:53:40 +0200
To:	Leon Timmermans via RT <bug-Module-Build-Tiny [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Fri, 28 Jun 2013 15:15:35 -0400, Leon Timmermans via RT wrote: Show quoted text

> > And I can't imagine how ExtUtils::Helpers should change the hardcoded > > values in lib/Module/Build/Tiny.pm: > > > > manify($_, catfile('blib', 'bindoc', man1_pagename($_)), 1, \%opt) for keys %scripts; > > manify($_, catfile('blib', 'libdoc', man3_pagename($_)), 3, \%opt) for keys %modules;

> I see, then I completely misunderstood what you meant.

Sorry if I was unclear ... Show quoted text

> Module::Build::Tiny is following Module::Build here, but Debian uses a > patched Module::Build. Probably Module::Build needs a similar patch.

That's what I already did in our git repo; but since %Config has the correct values, I thought it might be more elegant to re-use it. In any case, I'm also perfectly fine with carrying the tiny patch, if this is ok for you too. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Red Hot Chili Peppers: Fortune Faded

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Sat Jun 29 16:49:29 2013 LEONT [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #86551] Should use man1ext and man3ext
Date:	Sat, 29 Jun 2013 22:48:52 +0200
To:	bug-Module-Build-Tiny [...] rt.cpan.org
From:	Leon Timmermans <leont [...] cpan.org>

On Fri, Jun 28, 2013 at 10:54 PM, gregor herrmann via RT <bug-Module-Build-Tiny@rt.cpan.org> wrote: Show quoted text

> Queue: Module-Build-Tiny > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86551 > > > On Fri, 28 Jun 2013 15:15:35 -0400, Leon Timmermans via RT wrote: >

>> > And I can't imagine how ExtUtils::Helpers should change the hardcoded >> > values in lib/Module/Build/Tiny.pm: >> > >> > manify($_, catfile('blib', 'bindoc', man1_pagename($_)), 1, \%opt) for keys %scripts; >> > manify($_, catfile('blib', 'libdoc', man3_pagename($_)), 3, \%opt) for keys %modules;

>> I see, then I completely misunderstood what you meant.

> > Sorry if I was unclear ... >

>> Module::Build::Tiny is following Module::Build here, but Debian uses a >> patched Module::Build. Probably Module::Build needs a similar patch.

> > That's what I already did in our git repo; but since %Config has the > correct values, I thought it might be more elegant to re-use it. > > In any case, I'm also perfectly fine with carrying the tiny patch, if > this is ok for you too.

Released 0.024, with a fix for this issue. Leon

Sat Jun 29 16:52:11 2013 LEONT [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Jun 29 18:26:54 2013 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #86551] Should use man1ext and man3ext
Date:	Sun, 30 Jun 2013 00:26:24 +0200
To:	Leon Timmermans via RT <bug-Module-Build-Tiny [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Sat, 29 Jun 2013 16:49:29 -0400, Leon Timmermans via RT wrote: Show quoted text

> > That's what I already did in our git repo; but since %Config has the > > correct values, I thought it might be more elegant to re-use it. > > > > In any case, I'm also perfectly fine with carrying the tiny patch, if > > this is ok for you too.

> > Released 0.024, with a fix for this issue.

Great, thanks alot. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Rod Stewart: Tom Traubert's Blues (Waltzing Mathilda)

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.