Skip Menu |

This queue is for tickets about the POE CPAN distribution.

Report information
The Basics
Id: 8649
Status: resolved
Priority: 0/
Queue: POE
People
Owner: martijn [...] cpan.org
Requestors: chris [...] bingosnet.co.uk
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.3003
Fixed in: (no value)

History Show all quoted text
  Mon Nov 29 11:54:35 2004 BINGOS [...] cpan.org - Ticket created
Subject: Filter-Stackable forces get_one_start and get_one API on stacked filters
POE::Filter::Stackable is forcing the new filter API ( ie. get_one_start and get_one ) on stacked filters.
  Mon Nov 29 12:02:33 2004 martijn [...] cpan.org - Taken
  Thu Jun 30 23:45:35 2005 RCAPUTO [...] cpan.org - Correspondence added
[BINGOS - Mon Nov 29 11:54:35 2004]: Show quoted text
> POE::Filter::Stackable is forcing the new filter API ( ie. > get_one_start and get_one ) on stacked filters.
I forget. How important is this? I just rewrote the get_one() code for Filter::Stackable, and it shouldn't be hard to throw in some can() calls and conditionally do get() if necessary. In fact, the new code should be easier to do this with. So... what's the case where this is needed?
  Fri Jul 01 05:32:25 2005 Guest - Correspondence added
From: BINGOS
[RCAPUTO - Thu Jun 30 23:45:35 2005]: Show quoted text
> I forget. How important is this? I just rewrote the get_one() code > for > Filter::Stackable, and it shouldn't be hard to throw in some can() > calls > and conditionally do get() if necessary. In fact, the new code should > be easier to do this with. > > So... what's the case where this is needed?
Probably not important enough for that. POE::Filter appears to document the correct API now, so guessing that this can be closed. It would only be a problem I suppose if people attempt to stack filters that don't support the newer API, if you see what I mean.
  Fri Jul 01 09:46:34 2005 RCAPUTO [...] cpan.org - Status changed from 'new' to 'resolved'
  Fri Jul 01 09:46:34 2005 RCAPUTO [...] cpan.org - Correspondence added
Cool! This ticket's outtaheah! I recently removed get() from nearly all the filters that come with POE. Now POE::Filter includes an inheritable get() function that calls get_one_start() and get_one() to do its thing. Buhbye duplicated code! :)