| Subject: | Reactor does not set correct toggle_timeout callback in manage() |
| Date: | Mon, 24 Jun 2013 23:13:17 +0200 |
| To: | bug-Net-DBus [...] rt.cpan.org |
| From: | Daniel Hermann <daniel-hermann [...] 1und1.de> |
Hi,
as I was browsing the code of Net::DBus::Reactor, I recognized a
possible typo in the manage() function. Both the 'remove_timeout' and
'toggle_timeout' callbacks are calling $self->remove_timeout().
The 'toggle_timeout' callback should instead call $self->toggle_timeout():
--- Reactor.pm.orig 2013-06-24 23:10:54.517681653 +0200
+++ Reactor.pm 2013-06-24 23:11:07.469797300 +0200
@@ -225,7 +225,7 @@
my $timeout = shift;
my $key = $timeout->get_data;
- $self->remove_timeout($key,
+ $self->toggle_timeout($key,
$timeout->is_enabled,
$timeout->get_interval);
});
Found in Net::DBus version 1.0.0.
cheers,
Daniel