| Subject: | Re: send_packet dmac address explicitly not copied into target mac address in payload |
| Date: | Sun, 23 Jun 2013 09:07:03 +1000 |
| To: | bug-Net-ARP [...] rt.cpan.org |
| From: | Daniel Black <daniel.subs [...] internode.on.net> |
On 18/06/13 17:16, Daniel Black wrote:
Show quoted text
> I've found this is needed in large infrastructure providers (Linode) to
> get the message to the right address.
>
> ARP.xs
>
> - if(strcmp(dmac,"ff:ff:ff:ff:ff:ff"))
> memcpy(arp->dest_add,(u_char
> *)ether_aton(dmac),ETH_ALEN); // Destination MAC
>
>
> If this does need to be here for some reason then document it.
sorry to be a pain clarifying this after you've done a release but the
memcpy line still needs to be there, only the "if condition on it" needs
to be removed.