Skip Menu |

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 86305
Status: rejected
Priority: 0/
Queue: DBIx-Class
People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.08250
Fixed in: (no value)

History Show all quoted text
  Fri Jun 21 10:48:04 2013 daxim [...] cpan.org - Ticket created
Subject: console trace "Wide character in print"
DBIx::Class::Storage::Statistics::print generates the warning "Wide character in print at …/IO/Handle.pm line 417." when debugging with DBIC_TRACE=1 DBIC_TRACE_PROFILE=console and there's Unicode text in the SQL query. The message is passed through print unencoded, which is wrong. Adding `use Encode::Locale; binmode $self->debugfh, ':encoding(console_out)';` to this method works for me, but certainly you'll know a more appropriate place to add the encoding layer, e.g. when the handle is created.
  Sun Jan 12 15:29:49 2014 ribasushi [...] leporine.io - Correspondence added
On Fri Jun 21 10:48:04 2013, DAXIM wrote: Show quoted text
> DBIx::Class::Storage::Statistics::print generates the warning "Wide > character in print at …/IO/Handle.pm line 417." when debugging with > DBIC_TRACE=1 DBIC_TRACE_PROFILE=console and there's Unicode text in > the SQL query. > > The message is passed through print unencoded, which is wrong. Adding > `use Encode::Locale; binmode $self->debugfh, > ':encoding(console_out)';` to this method works for me, but certainly > you'll know a more appropriate place to add the encoding layer, e.g. > when the handle is created.
I thought a lot about this ticket and am going to reject it. Setting aside the question whether it is "wrong" to print to a filehandle using its default settings, there is a practical problem with your suggestion. If we *do* set unicode mode on STDOUT, we will start seeing exceptions when DBIC attempts to output plain-high-byte-latin (say from Win1252 columns). It is not acceptable for the trace code to introduce its own exceptions.
  Sun Jan 12 15:29:51 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Jan 12 15:29:51 2014 ribasushi [...] leporine.io - Status changed from 'open' to 'rejected'