Bug #86199 for Message-Passing-Filter-Regexp: make @message and @fields configurable

Mon Jun 17 03:34:37 2013 abraxxa [...] cpan.org - Ticket created

Subject:

make @message and @fields configurable

Hi Rao, I'd appreciate if you make configurable where the message string to be parsed is taken from (currently $message->{'@message'} ), and where the captured parts are stored in the message (currently $message->{'@fields'} ). I'm using Message::Passing::Input::Syslog which puts the message into $message->{message} and ->{content} depending on what you prefer. There might be also a situation where $message is a plain string and not a hash in which case it should be used as is regardless of the configured message source. Thanks!

Mon Jun 17 05:00:24 2013 rao.chenlin [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #86199] make @message and @fields configurable
Date:	Mon, 17 Jun 2013 17:00:04 +0800
To:	bug-Message-Passing-Filter-Regexp [...] rt.cpan.org
From:	chenlin rao <rao.chenlin [...] gmail.com>

Currently I use Filter::Regexp after Filter::ToLogstash, $message would be parsed to such format by this filter. Has you try this filter? Anyway, I will try to make these two field configurable. 2013/6/17 Alexander Hartmaier via RT < bug-Message-Passing-Filter-Regexp@rt.cpan.org> Show quoted text

> Mon Jun 17 03:34:37 2013: Request 86199 was acted upon. > Transaction: Ticket created by ABRAXXA > Queue: Message-Passing-Filter-Regexp > Subject: make @message and @fields configurable > Broken in: 0.03 > Severity: Wishlist > Owner: Nobody > Requestors: alex.hartmaier@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86199 > > > > Hi Rao, > I'd appreciate if you make configurable where the message string to be > parsed is taken from (currently $message->{'@message'} ), and where the > captured parts are stored in the message (currently $message->{'@fields'} ). > > I'm using Message::Passing::Input::Syslog which puts the message into > $message->{message} and ->{content} depending on what you prefer. > There might be also a situation where $message is a plain string and not a > hash in which case it should be used as is regardless of the configured > message source. > > Thanks! >

Mon Jun 17 05:00:25 2013 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 17 10:15:11 2013 abraxxa [...] cpan.org - Correspondence added

I don't use Filter::ToLogstash because I need more control about the message fields. Thanks for looking into it!

Wed Jun 19 01:57:46 2013 rao.chenlin [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #86199] make @message and @fields configurable
Date:	Wed, 19 Jun 2013 13:57:32 +0800
To:	bug-Message-Passing-Filter-Regexp [...] rt.cpan.org
From:	chenlin rao <rao.chenlin [...] gmail.com>

add a `fromto` attr.Please give a try~ 2013/6/17 Alexander Hartmaier via RT < bug-Message-Passing-Filter-Regexp@rt.cpan.org> Show quoted text

> Queue: Message-Passing-Filter-Regexp > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86199 > > > I don't use Filter::ToLogstash because I need more control about the > message fields. > Thanks for looking into it! >

Wed Jun 19 02:50:45 2013 abraxxa [...] cpan.org - Correspondence added

Works, thanks! It could be a bit more flexible, e.g. if you want to put the captured fields directly into the message hashref. Maybe add support for that via @message => undef or @message => ''. Do you know why logstash puts them in the subhash @fields?

Wed Jun 19 04:28:41 2013 rao.chenlin [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #86199] make @message and @fields configurable
Date:	Wed, 19 Jun 2013 16:28:28 +0800
To:	bug-Message-Passing-Filter-Regexp [...] rt.cpan.org
From:	chenlin rao <rao.chenlin [...] gmail.com>

I think author only want the message hash has fixed list of keys for better look (and parse)? He use '@' prefix for these public keys but not for the keys of sub hash. Seems like the instance var and var in Ruby. 2013/6/19 Alexander Hartmaier via RT < bug-Message-Passing-Filter-Regexp@rt.cpan.org> Show quoted text

> Queue: Message-Passing-Filter-Regexp > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86199 > > > Works, thanks! > It could be a bit more flexible, e.g. if you want to put the captured > fields directly into the message hashref. > Maybe add support for that via @message => undef or @message => ''. > > Do you know why logstash puts them in the subhash @fields? >

Fri Jul 12 05:44:45 2013 abraxxa [...] cpan.org - Correspondence added

To make it more flexible I've added support for fromto => { message => undef }: Replace line 98 of version 0.04 with: if (defined $to) { $message->{$to} = {%data}; } # put parsed fields directly in message hashref else { %$message = ( %$message, %data ); }

Fri Jul 12 06:22:38 2013 rao.chenlin [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #86199] make @message and @fields configurable
Date:	Fri, 12 Jul 2013 18:22:21 +0800
To:	bug-Message-Passing-Filter-Regexp [...] rt.cpan.org
From:	chenlin rao <rao.chenlin [...] gmail.com>

well, ok. I will upload v0.05 for this. Tks 2013/7/12 Alexander Hartmaier via RT < bug-Message-Passing-Filter-Regexp@rt.cpan.org> Show quoted text

> Queue: Message-Passing-Filter-Regexp > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86199 > > > To make it more flexible I've added support for fromto => { message => > undef }: > > Replace line 98 of version 0.04 with: > > if (defined $to) { > $message->{$to} = {%data}; > } > # put parsed fields directly in message hashref > else { > %$message = ( %$message, %data ); > } >

Thu Aug 01 12:12:15 2013 abraxxa [...] cpan.org - Correspondence added

Works fine, thanks! You can close the ticket.

Thu Aug 01 19:29:14 2013 CHENRYN [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Aug 01 19:29:15 2013 CHENRYN [...] cpan.org - Fixed in 0.05 added