Skip Menu |

This queue is for tickets about the Finance-Bitcoin CPAN distribution.

Report information
The Basics
Id: 86193
Status: resolved
Priority: 0/
Queue: Finance-Bitcoin

People
Owner: Nobody in particular
Requestors: rene.schickbauer [...] magnapowertrain.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.900
Fixed in: (no value)



Subject: Broken with new versions of JSON::RPC
JSON::RPC changed the file names. In this specific case, the file JSON::RPC::Client was renamed to JSON::RPC::Legacy::Client. I attached a patch that should fix the problem. I only did very limited testing, though.
Subject: Finance-Bitcoin_newjsonrpc.patch
diff -rupN Finance-Bitcoin-0.900_orig/lib/Finance/Bitcoin/API.pm Finance-Bitcoin-0.900/lib/Finance/Bitcoin/API.pm --- Finance-Bitcoin-0.900_orig/lib/Finance/Bitcoin/API.pm 2013-06-09 01:05:38.241157992 +0200 +++ Finance-Bitcoin-0.900/lib/Finance/Bitcoin/API.pm 2013-06-09 01:11:04.920478147 +0200 @@ -8,13 +8,13 @@ BEGIN { use 5.010; use Moo; -use JSON::RPC::Client; +use JSON::RPC::Legacy::Client; use Moo; use Object::AUTHORITY; use Scalar::Util qw( blessed ); has endpoint => (is => "rw", default => sub { "http://127.0.0.1:8332/" }); -has jsonrpc => (is => "lazy", default => sub { "JSON::RPC::Client"->new }); +has jsonrpc => (is => "lazy", default => sub { "JSON::RPC::Legacy::Client"->new }); has error => (is => "rwp"); sub call @@ -85,7 +85,7 @@ Get/set the endpoint URL. =item C<< jsonrpc >> -Retrieve a reference to the L<JSON::RPC::Client> object being used. In particular +Retrieve a reference to the L<JSON::RPC::Legacy::Client> object being used. In particular C<< $api->jsonrpc->ua >> can be useful if you need to alter timeouts or HTTP proxy settings. diff -rupN Finance-Bitcoin-0.900_orig/meta/makefile.ttl Finance-Bitcoin-0.900/meta/makefile.ttl --- Finance-Bitcoin-0.900_orig/meta/makefile.ttl 2013-06-09 01:05:38.225157434 +0200 +++ Finance-Bitcoin-0.900/meta/makefile.ttl 2013-06-09 01:10:39.923612536 +0200 @@ -8,6 +8,6 @@ :readme_from _:main ; :requires "Moo"; :requires "Object::AUTHORITY"; - :requires "JSON::RPC::Client 0.93". + :requires "JSON::RPC::Legacy::Client 1.03". _:main <http://www.semanticdesktop.org/ontologies/2007/03/22/nfo#fileName> "lib/Finance/Bitcoin.pm" . diff -rupN Finance-Bitcoin-0.900_orig/META.ttl Finance-Bitcoin-0.900/META.ttl --- Finance-Bitcoin-0.900_orig/META.ttl 2013-06-09 01:05:38.225157434 +0200 +++ Finance-Bitcoin-0.900/META.ttl 2013-06-09 01:07:43.997522169 +0200 @@ -15,7 +15,7 @@ dist:project doap:name "Finance-Bitcoin"; cpant:perl_version_from _:B1; cpant:readme_from _:B1; - cpant:requires "JSON::RPC::Client 0.93"; + cpant:requires "JSON::RPC::Legacy::Client 1.03"; cpant:requires "Moo"; cpant:requires "Object::AUTHORITY"; cpant:version_from _:B1; diff -rupN Finance-Bitcoin-0.900_orig/META.yml Finance-Bitcoin-0.900/META.yml --- Finance-Bitcoin-0.900_orig/META.yml 2013-06-09 01:05:38.225157434 +0200 +++ Finance-Bitcoin-0.900/META.yml 2013-06-09 01:07:56.453953296 +0200 @@ -32,7 +32,7 @@ no_index: - t - xt requires: - JSON::RPC::Client: 0.93 + JSON::RPC::Legacy::Client: 1.03 Moo: 0 Object::AUTHORITY: 0 perl: 5.10.0
Thanks muchly. I've just released Finance-Bitcoin-0.901.