Skip Menu |

This queue is for tickets about the NetAddr-MAC CPAN distribution.

Report information
The Basics
Id: 86093
Status: resolved
Priority: 0/
Queue: NetAddr-MAC

People
Owner: Nobody in particular
Requestors: OLIVER [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Silently accepting bogus MAC address data
Hi, I am considering migrating a project of mine from Net::MAC to NetAddr::MAC. One of the things I need to do is sanity check user input by using the module to reject bogus MAC address data. I found that NetAddr::MAC silently accepts two bogus formats: an empty string, and a short address. Here are some tests for bogus MAC formats: https://gist.github.com/ollyg/5766262 If you agree these two cases need fixing, I'll fork the project on github and write a patch. regards, oliver.
Subject: Re: [rt.cpan.org #86093] Silently accepting bogus MAC address data
Date: Thu, 13 Jun 2013 07:50:23 +1000
To: "bug-NetAddr-MAC [...] rt.cpan.org" <bug-NetAddr-MAC [...] rt.cpan.org>
From: Dean Hamstead <dean [...] fragfest.com.au>
They should all be rejected you are right. Infact I thought they were. Please fork and add any features you like! On 13/06/2013, at 1:24 AM, "Oliver Gorwits via RT" <bug-NetAddr-MAC@rt.cpan.org> wrote: Show quoted text
> Wed Jun 12 11:24:22 2013: Request 86093 was acted upon. > Transaction: Ticket created by OLIVER > Queue: NetAddr-MAC > Subject: Silently accepting bogus MAC address data > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: OLIVER@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86093 > > > > Hi, > > I am considering migrating a project of mine from Net::MAC to NetAddr::MAC. One of the things I need to do is sanity check user input by using the module to reject bogus MAC address data. > > I found that NetAddr::MAC silently accepts two bogus formats: an empty string, and a short address. > > Here are some tests for bogus MAC formats: https://gist.github.com/ollyg/5766262 > > If you agree these two cases need fixing, I'll fork the project on github and write a patch. > > regards, > oliver.
this is now resolved in teh latest version.