Skip Menu |

This queue is for tickets about the CGI-Application-Plugin-Authentication CPAN distribution.

Report information
The Basics
Id: 85969
Status: open
Priority: 0/
Queue: CGI-Application-Plugin-Authentication

People
Owner: Nobody in particular
Requestors: gregoa [...] debian.org
Cc: dam [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From: gregoa [...] cpan.org
Subject: libcgi-application-plugin-authentication-perl: FTBFS with perl 5.18: test failures
This bug has been forwarded from http://bugs.debian.org/711428 Source: libcgi-application-plugin-authentication-perl Version: 0.20-1 Severity: important User: debian-perl@lists.debian.org Usertags: perl-5.18-transition Tags: sid jessie This package FTBFS with perl 5.18 from experimental (in a clean sbuild session): t/03_destination.t .................. ok # Failed test 'default - _detaint_selfurl' # at t/03_login_box.t line 121. # got: 'http://localhost?authen_username=user1;rm=two' # expected: 'http://localhost?rm=two;authen_username=user1' # Failed test 'default - verify login box' # at /usr/share/perl5/Test/Regression.pm line 83. .... This looks very much like hash randomisation issues. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) Thanks in advance, gregor herrmann, Debian Perl Group
I tried to fix this but there is WAY too much involved. Basically, testing literal html against generated html is bound to fail for more reasons than one, and generated links have tickled the hash ordering, as suspected. If you want to fix this you should test the structure of the html some other way, maybe with HTML::TreeBuilder. Testing links (for example, line 121 in t/03_login_box.t) should use URI::eq instead of simple equality. For those poor souls who will surely be waiting a while till this is fixed, get a hacked version with cpanm git://github.com/frioux/cgi-application-plugin-authentication
На 23 юли 2013, вт 22:50:18, frew написа: Show quoted text
> I tried to fix this but there is WAY too much involved. Basically, > testing literal html against generated html is bound to fail for more > reasons than one, and generated links have tickled the hash ordering, > as suspected. > > If you want to fix this you should test the structure of the html some > other way, maybe with HTML::TreeBuilder. Testing links (for example, > line 121 in t/03_login_box.t) should use URI::eq instead of simple > equality.
Unfortunately URI::eq does not handle parameter reordering: $ perl -MURI -wE'say URI::eq("http://lh?a=b;b=a", "http://lh?b=a;a=b") ? "yes" : "no"' no Show quoted text
> For those poor souls who will surely be waiting a while till this is > fixed, get a hacked version with cpanm git://github.com/frioux/cgi- > application-plugin-authentication
Yeah, it seems that skipping the affected tests is the only option.