Skip Menu |

This queue is for tickets about the User-Simple CPAN distribution.

Report information
The Basics
Id: 85966
Status: open
Priority: 0/
Queue: User-Simple
People
Owner: Nobody in particular
Requestors: gregoa [...] debian.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)
Attachments
pod-encoding.patch
qw-list.patch
signature.asc

History Show all quoted text
  Fri Jun 07 20:10:21 2013 gregoa [...] cpan.org - Ticket created
From: gregoa [...] cpan.org
Subject: libuser-simple-perl: FTBFS with perl 5.18: POD
This bug has been forwarded from http://bugs.debian.org/711394 Source: libuser-simple-perl Version: 1.43-1 Severity: important User: debian-perl@lists.debian.org Usertags: perl-5.18-transition Tags: sid jessie This package FTBFS with perl 5.18 from experimental (in a clean sbuild session): # Failed test 'use User::Simple::Admin;' # at t/User-Simple.t line 14. # Tried to use 'User::Simple::Admin'. # Error: syntax error at /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/ libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 342, near "$case qw( id ID Id iD)" # Global symbol "$case" requires explicit package name at /build/dom-libuser-sim ple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin. pm line 343. # Global symbol "$id" requires explicit package name at /build/dom-libuser-simpl e-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 344. # Global symbol "$case" requires explicit package name at /build/dom-libuser-sim ple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin. pm line 344. # syntax error at /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/libuser-simp le-perl-1.43/blib/lib/User/Simple/Admin.pm line 347, near "}" # Global symbol "$id" requires explicit package name at /build/dom-libuser-simpl e-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 348. # Global symbol "$in_field" requires explicit package name at /build/dom-libuser -simple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Ad min.pm line 349. # Global symbol "%users" requires explicit package name at /build/dom-libuser-si mple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin .pm line 352. # Global symbol "$id" requires explicit package name at /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 352. # Global symbol "$row" requires explicit package name at /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 352. # Global symbol "$in_field" requires explicit package name at /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 352. # syntax error at /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm line 353, near "}" # /build/dom-libuser-simple-perl_1.43-1-i386-Y7Vbs6/libuser-simple-perl-1.43/blib/lib/User/Simple/Admin.pm has too many errors. # Compilation failed in require at (eval 16) line 2. # BEGIN failed--compilation aborted at (eval 16) line 2. Can't locate object method "new_user" via package "User::Simple::Admin" at t/User-Simple.t line 40. # Looks like you planned 40 tests but ran 3. # Looks like you failed 1 test of 3 run. # Looks like your test exited with 2 just after 3. t/User-Simple.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 38/40 subtests # Failed test 'POD test for blib/lib/User/Simple.pm' # at /usr/share/perl5/Test/Pod.pm line 182. # blib/lib/User/Simple.pm (161): Non-ASCII character seen before =encoding in 'Econ<F3>micas'. Assuming ISO8859-1 # Failed test 'POD test for blib/lib/User/Simple/Admin.pm' # at /usr/share/perl5/Test/Pod.pm line 182. # blib/lib/User/Simple/Admin.pm (201): Non-ASCII character seen before =encoding in 'Econ<F3>micas'. Assuming ISO8859-1 # Looks like you failed 2 tests of 2. Failed 2/2 test programs. 3/5 subtests failed. t/pod.t .......... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- t/User-Simple.t (Wstat: 512 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 2 Parse errors: Bad plan. You planned 40 tests but ran 3. t/pod.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=2, Tests=5, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.20 cusr 0.03 csys = 0.27 CPU) Result: FAIL -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) Thanks in advance, gregor herrmann, Debian Perl Group
  Sun Jun 16 12:44:09 2013 gregoa [...] cpan.org - Correspondence added
This are actually two issues: - using qw() in list context - missing =encoding in the POD Patches for both bugs attached. Cheers, gregor, Debian Perl Group
Subject: pod-encoding.patch
Description: add encoding to POD, Pod::Simple is more strict now Origin: vendor Bug: https://rt.cpan.org/Ticket/Display.html?id=85966 Forwarded: https://rt.cpan.org/Ticket/Display.html?id=85966 Bug-Debian: http://bugs.debian.org/711394 Author: gregor herrmann <gregoa@debian.org> Last-Update: 2013-06-16 --- a/lib/User/Simple.pm +++ b/lib/User/Simple.pm @@ -3,6 +3,8 @@ package User::Simple; +=encoding ISO8859-1 + =head1 NAME User::Simple - Simple user sessions management --- a/lib/User/Simple/Admin.pm +++ b/lib/User/Simple/Admin.pm @@ -3,6 +3,8 @@ package User::Simple::Admin; +=encoding ISO8859-1 + =head1 NAME User::Simple::Admin - User::Simple user administration
Subject: qw-list.patch
Description: qw() in list context is an error with newer perls Origin: vendor Bug: https://rt.cpan.org/Ticket/Display.html?id=85966 Forwarded: https://rt.cpan.org/Ticket/Display.html?id=85966 Bug-Debian: http://bugs.debian.org/711394 Author: gregor herrmann <gregoa@debian.org> Last-Update: 2013-06-16 --- a/lib/User/Simple/Admin.pm +++ b/lib/User/Simple/Admin.pm @@ -339,7 +339,7 @@ # sensitive. Gah, we work around that to provide the much more # common lowercase fields... This might still have some problems # attached, please tell me if it breaks for you. - for my $case qw(id ID Id iD) { + for my $case (qw(id ID Id iD)) { if (exists $row->{$case}) { $id = $row->{$case}; last;
  Sun Jun 16 12:44:09 2013 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 18 14:24:34 2013 gwolf [...] gwolf.org - Correspondence added
Subject: Re: [rt.cpan.org #85966] libuser-simple-perl: FTBFS with perl 5.18: POD
Date: Tue, 18 Jun 2013 13:24:19 -0500
To: gregor herrmann via RT <bug-User-Simple [...] rt.cpan.org>
From: Gunnar Wolf <gwolf [...] gwolf.org>
gregor herrmann via RT dijo [Fri, Jun 07, 2013 at 08:10:21PM -0400]: Show quoted text
> Fri Jun 07 20:10:21 2013: Request 85966 was acted upon. > Transaction: Ticket created by GREGOA > Queue: User-Simple > Subject: libuser-simple-perl: FTBFS with perl 5.18: POD > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: gregoa@debian.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85966 >
Always nice to read you :) I have just uploaded a 1.44 version. I am not sure if this module is worth keeping, as it is too simple and I doubt of its utility. But if there is any demand for it, well, there it is :) Greetings+hugs!
  Tue Jun 18 14:36:37 2013 gregoa [...] debian.org - Correspondence added
Subject: Re: [rt.cpan.org #85966] libuser-simple-perl: FTBFS with perl 5.18: POD
Date: Tue, 18 Jun 2013 20:36:14 +0200
To: Gunnar Wolf via RT <bug-User-Simple [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
On Tue, 18 Jun 2013 14:24:35 -0400, Gunnar Wolf via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=85966 > > > gregor herrmann via RT dijo [Fri, Jun 07, 2013 at 08:10:21PM -0400]:
> > Fri Jun 07 20:10:21 2013: Request 85966 was acted upon. > > Transaction: Ticket created by GREGOA > > Queue: User-Simple > > Subject: libuser-simple-perl: FTBFS with perl 5.18: POD > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: gregoa@debian.org > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85966 >
> > Always nice to read you :)
And vice versa :) Show quoted text
> I have just uploaded a 1.44 version.
¡Gracias! Show quoted text
> I am not sure if this module is > worth keeping, as it is too simple and I doubt of its utility. But if > there is any demand for it, well, there it is :)
Me neither, but as long as bugs are easy to fix we might just do it :) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Rolling Stones: 19th Nervous Breakdown
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

  Tue Jun 18 14:46:06 2013 gregoa [...] debian.org - Correspondence added
Subject: Re: [rt.cpan.org #85966] libuser-simple-perl: FTBFS with perl 5.18: POD
Date: Tue, 18 Jun 2013 20:45:45 +0200
To: Gunnar Wolf via RT <bug-User-Simple [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
On Tue, 18 Jun 2013 14:24:35 -0400, Gunnar Wolf via RT wrote: Show quoted text
> > Queue: User-Simple > > Subject: libuser-simple-perl: FTBFS with perl 5.18: POD
Show quoted text
> I have just uploaded a 1.44 version.
It's me again :) Thanks for merging the qw()-patch. And converting the POD to UTF-8 is a good idea; but Pod::Simple from perl 5.18 still needs an explicit =encoding in the POD, otherwise we still get: # Failed test 'POD test for blib/lib/User/Simple.pm' # at /usr/share/perl5/Test/Pod.pm line 186. # blib/lib/User/Simple.pm (161): Non-ASCII character seen before =encoding in 'Económicas'. Assuming UTF-8 # Failed test 'POD test for blib/lib/User/Simple/Admin.pm' # at /usr/share/perl5/Test/Pod.pm line 186. # blib/lib/User/Simple/Admin.pm (201): Non-ASCII character seen before =encoding in 'Económicas'. Assuming UTF-8 # Looks like you failed 2 tests of 2. t/pod.t .......... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- t/pod.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=2, Tests=42, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.21 cusr 0.04 csys = 0.29 CPU) Result: FAIL Failed 1/2 test programs. 2/42 subtests failed. Find attached an updated patch for the encoding. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Beatles

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

  Tue Jun 18 17:27:24 2013 gwolf [...] gwolf.org - Correspondence added
Subject: Re: [rt.cpan.org #85966] libuser-simple-perl: FTBFS with perl 5.18: POD
Date: Tue, 18 Jun 2013 16:27:10 -0500
To: gregor herrmann via RT <bug-User-Simple [...] rt.cpan.org>
From: Gunnar Wolf <gwolf [...] gwolf.org>
gregor herrmann via RT dijo [Tue, Jun 18, 2013 at 02:46:06PM -0400]: Show quoted text
> Queue: User-Simple > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85966 > > > On Tue, 18 Jun 2013 14:24:35 -0400, Gunnar Wolf via RT wrote: >
> > > Queue: User-Simple > > > Subject: libuser-simple-perl: FTBFS with perl 5.18: POD
>
> > I have just uploaded a 1.44 version.
> > It's me again :) > > Thanks for merging the qw()-patch. > > And converting the POD to UTF-8 is a good idea; but Pod::Simple from > perl 5.18 still needs an explicit =encoding in the POD, otherwise we > still get: > > # Failed test 'POD test for blib/lib/User/Simple.pm' > (...) > Failed 2/2 subtests
Bah. Fixed, bumped up yet one more hundredth of a version ;-) Thanks!
  Tue Jun 18 17:45:34 2013 gregoa [...] debian.org - Correspondence added
Subject: Re: [rt.cpan.org #85966] libuser-simple-perl: FTBFS with perl 5.18: POD
Date: Tue, 18 Jun 2013 23:45:09 +0200
To: Gunnar Wolf via RT <bug-User-Simple [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
On Tue, 18 Jun 2013 17:27:25 -0400, Gunnar Wolf via RT wrote: Show quoted text
> > And converting the POD to UTF-8 is a good idea; but Pod::Simple from > > perl 5.18 still needs an explicit =encoding in the POD, otherwise we > > still get: > > > > # Failed test 'POD test for blib/lib/User/Simple.pm' > > (...) > > Failed 2/2 subtests
> > Bah. Fixed, bumped up yet one more hundredth of a version ;-)
Thanks again :) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Dhafer Youssef: Odd Poetry
Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.