Bug #85917 for JSON: 14 files have shebang (#!)

Thu Jun 06 03:44:23 2013 nbarth [...] google.com - Ticket created

Subject:

14 files have shebang (#!)

The following 14 files start with a shebang (#!) line, but are not executable. (Noticed because an upload script flagged this.) I think the solution is: * the 2 eg/ files should be made executable, as they are actual examples (there are only 2 eg/ files) * the 12 t/ files should have the #! removed, as they are called by a script during testing (there are 58 t/ files, and the other 46 have no #!) The files are: eg/bench_decode.pl eg/bench_encode.pl t/19_incr.t t/20_unknown.t t/e02_bool.t t/e13_overloaded_eq.t t/e14_decode_prefix.t t/e16_incr_parse_fixed.t t/e90_misc.t t/xe02_bool.t

Mon Sep 12 09:55:30 2016 ishigaki [...] cpan.org - Correspondence added

On Thu Jun 06 16:44:23 2013, nbarth@google.com wrote: Show quoted text

> The following 14 files start with a shebang (#!) line, but are not > executable. > (Noticed because an upload script flagged this.) > > I think the solution is: > * the 2 eg/ files should be made executable, as they are actual > examples (there are only 2 eg/ files) > * the 12 t/ files should have the #! removed, as they are called by a > script during testing > (there are 58 t/ files, and the other 46 have no #!) > > The files are: > eg/bench_decode.pl > eg/bench_encode.pl > > t/19_incr.t > t/20_unknown.t > t/e02_bool.t > t/e13_overloaded_eq.t > t/e14_decode_prefix.t > t/e16_incr_parse_fixed.t > t/e90_misc.t > t/xe02_bool.t

Thanks. Fixed with https://github.com/makamaka/JSON/commit/e26e377285e6e48f045f1aa5afde6aa4e6d74284

Mon Sep 12 09:55:30 2016 The RT System itself - Status changed from 'new' to 'open'

Mon Sep 12 09:55:35 2016 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Tue Jun 20 03:59:15 2017 ishigaki [...] cpan.org - Correspondence added

On Mon Sep 12 22:55:30 2016, ISHIGAKI wrote: Show quoted text

> On Thu Jun 06 16:44:23 2013, nbarth@google.com wrote:

> > The following 14 files start with a shebang (#!) line, but are not > > executable. > > (Noticed because an upload script flagged this.) > > > > I think the solution is: > > * the 2 eg/ files should be made executable, as they are actual > > examples (there are only 2 eg/ files) > > * the 12 t/ files should have the #! removed, as they are called by a > > script during testing > > (there are 58 t/ files, and the other 46 have no #!) > > > > The files are: > > eg/bench_decode.pl > > eg/bench_encode.pl > > > > t/19_incr.t > > t/20_unknown.t > > t/e02_bool.t > > t/e13_overloaded_eq.t > > t/e14_decode_prefix.t > > t/e16_incr_parse_fixed.t > > t/e90_misc.t > > t/xe02_bool.t

> > > Thanks. Fixed with > https://github.com/makamaka/JSON/commit/e26e377285e6e48f045f1aa5afde6aa4e6d74284

Closed as 2.92 was released. Thanks.

Tue Jun 20 03:59:16 2017 ishigaki [...] cpan.org - Status changed from 'patched' to 'resolved'