| Subject: | Net::Telnet uses $[ instead of 0 for no reason |
Net/Telnet.pm uses $[ in 10 different places (all copy/pasted). I think this is bad for the following reasons:
- $[ has been lexically scoped since perl 5.0. As Net::Telnet never assigns to $[, all uses can be replaced by 0.
- $[ has been deprecated since perl 5.12.
- $[ has been implemented by the arybase module since perl 5.16. This causes problems if you try to package a script that uses Net::Telnet with PAR, because now it has an implicit dependency on arybase.pm that causes it to fail at runtime ("Can't locate arybase.pm in @INC (@INC contains: CODE(0x305bea4) C:\Users\mtfnpy\AppData\Local\Temp\par-676e657362697474\cache-8626900a7b1b9ce2a53ed68130e74d83c25afc8f\inc\lib C:\Users\mtfnpy\AppData\Local\Temp\par-676e657362697474\cache-8626900a7b1b9ce2a53ed68130e74d83c25afc8f\inc CODE(0x2df2c44) CODE(0x2df2fd4)) at Net/Telnet.pm line 536.").
The last problem can be worked around by adding an explicit 'use arybase' to the script (or otherwise telling PAR::Packer to include arybase) but there's no reason for Net::Telnet to use $[ in the first place.