Bug #85895 for Type-Tiny: Type comparison not working on 5.8

Wed Jun 05 13:39:56 2013 MMCLERIC [...] cpan.org - Ticket created

Subject:

Type comparison not working on 5.8

See: mmcleric@dhcp173-77-red:~$ perlbrew exec perl -MTypes::Standard=-types -e 'Bool eq Bool; print "ok\n"' perl-5.16.1 ========== ok perl-5.8.8 ========== Operation "eq": no method found, left argument in overloaded package Type::Tiny, right argument in overloaded package Type::Tiny at -e line 1. PS: One case where this is an issue is when I use Type::Tiny with Moose and diamond role application, and Moose compares attribute definitions to see if there's a conflict (see is_same_as() method in Moose::Meta::Role::Attribute).

Thu Jun 06 15:33:14 2013 perl [...] toby.ink - Correspondence added

I'd recommend using "==" to compare types, or the "equals"/"is_subtype_of"/etc methods. The reason being that two type libraries could define different type constraints called "Bool" (for example an XML type constraint library might expect bools to be strings matching /^(true|false|1|0)$/), and "eq" will just compare the type constraint names as strings, which isn't a good indication that they're the same type. I will try to fix overloading for eq soon, simply because I dislike the "no overloaded magic" error message. But I don't recommend eq to check types.

Thu Jun 06 15:33:14 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 06 16:52:27 2013 me [...] berekuk.ru - Correspondence added

Subject:	Re: [rt.cpan.org #85895] Type comparison not working on 5.8
Date:	Fri, 07 Jun 2013 00:52:05 +0400
To:	"bug-Type-Tiny [...] rt.cpan.org" <bug-type-tiny [...] rt.cpan.org>
From:	Vyacheslav Matyukhin <me [...] berekuk.ru>

So you're saying that Moose should be patched? 06.06.2013, 23:33, "Toby Inkster via RT" <bug-Type-Tiny@rt.cpan.org>: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=85895 > > > I'd recommend using "==" to compare types, or the "equals"/"is_subtype_of"/etc methods. > > The reason being that two type libraries could define different type constraints called "Bool" (for example an XML type constraint library might expect bools to be strings matching /^(true|false|1|0)$/), and "eq" will just compare the type constraint names as strings, which isn't a good indication that they're the same type. > > I will try to fix overloading for eq soon, simply because I dislike the "no overloaded magic" error message. But I don't recommend eq to check types.

Fri Jun 07 08:46:39 2013 perl [...] toby.ink - Correspondence added

I missed the part where you said that Moose does this. Moose possibly should be patched; but I think Type::Tiny will need to workaround it.

Sun Jun 09 08:21:12 2013 perl [...] toby.ink - Correspondence added

Fixed in repo

Sun Jun 09 08:21:12 2013 perl [...] toby.ink - Status changed from 'open' to 'patched'

Sun Jun 09 11:54:19 2013 perl [...] toby.ink - Correspondence added

0.007_04 fixes this issue. Not sure when the next stable release will be yet. Soonish.

Fri Jun 21 08:28:02 2013 perl [...] toby.ink - Correspondence added

Fixed in 0.008.

Fri Jun 21 08:28:03 2013 perl [...] toby.ink - Status changed from 'patched' to 'resolved'