Bug #85878 for File-Path: Installation fails during test

Wed Jun 05 04:58:43 2013 valery.svistunov [...] gmail.com - Ticket created

Subject:	Installation fails during test
Date:	Wed, 5 Jun 2013 11:58:28 +0300
To:	bug-File-Path [...] rt.cpan.org
From:	Валерий Свистунов <valery.svistunov [...] gmail.com>

Good day. There is a small bug in installation script. Seems like type mistake (here is a part of log file): # Failed test 'created a directory not owned by nobodz:nogrouq...' # at t/Path.t line 503. # STDERR: # unable to map nobodz to a uid, ownership not changed: at t/Path.t line 501. # unable to map nogrouq to a gid, group ownership not changed: at t/Path.t line 501. # # doesn't match: # (?^:\Aunable to map nobodz to a uid, ownership not changed: .* at \S+ line \d+ # unable to map nogrouq to a gid, group ownership not changed: .* at \S+ line \d+\b) # as expected # Looks like you failed 1 test of 129. t/Path.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/129 subtests (less 29 skipped subtests: 99 okay) t/pod.t .... skipped: PERL_AUTHOR_TESTING environment variable not set (or zero) t/taint.t .. ok "nobodz:nogrouq" should be "nobody:nogroup" Best regards, Valery Svistunov

Tue Nov 12 17:14:48 2013 SREZIC [...] cpan.org - Correspondence added

On 2013-06-05 04:58:43, valery.svistunov@gmail.com wrote: Show quoted text

> Good day. > > There is a small bug in installation script. Seems like type mistake (here > is a part of log file): > > # Failed test 'created a directory not owned by nobodz:nogrouq...' > # at t/Path.t line 503. > # STDERR: > # unable to map nobodz to a uid, ownership not changed: at t/Path.t line > 501. > # unable to map nogrouq to a gid, group ownership not changed: at t/Path.t > line 501. > # > # doesn't match: > # (?^:\Aunable to map nobodz to a uid, ownership not changed: .* at \S+ > line \d+ > # unable to map nogrouq to a gid, group ownership not changed: .* at \S+ > line \d+\b) > # as expected > # Looks like you failed 1 test of 129. > t/Path.t ... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/129 subtests > (less 29 skipped subtests: 99 okay) > t/pod.t .... skipped: PERL_AUTHOR_TESTING environment variable not set (or > zero) > t/taint.t .. ok > > "nobodz:nogrouq" should be "nobody:nogroup" >

I think it's another issue here. Older version of Carp.pm used to output a message without a trailing dot (i.e. "line 501"). Newer Carp.pm versions output the message with a trailing dot (i.e. "line 501."). So the real fix is to accept the trailing dot in the regexp. Regards, Slaven

Tue Nov 12 17:14:49 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 12 17:15:13 2013 SREZIC [...] cpan.org - Cc SREZIC added

Wed Apr 15 22:07:57 2015 jkeenan [...] cpan.org - Correspondence added

On Tue Nov 12 17:14:48 2013, SREZIC wrote: Show quoted text

> On 2013-06-05 04:58:43, valery.svistunov@gmail.com wrote:

> > Good day. > > > > There is a small bug in installation script. Seems like type mistake > > (here > > is a part of log file): > > > > # Failed test 'created a directory not owned by nobodz:nogrouq...' > > # at t/Path.t line 503. > > # STDERR: > > # unable to map nobodz to a uid, ownership not changed: at t/Path.t > > line > > 501. > > # unable to map nogrouq to a gid, group ownership not changed: at > > t/Path.t > > line 501. > > # > > # doesn't match: > > # (?^:\Aunable to map nobodz to a uid, ownership not changed: .* at > > \S+ > > line \d+ > > # unable to map nogrouq to a gid, group ownership not changed: .* at > > \S+ > > line \d+\b) > > # as expected > > # Looks like you failed 1 test of 129. > > t/Path.t ... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/129 subtests > > (less 29 skipped subtests: 99 okay) > > t/pod.t .... skipped: PERL_AUTHOR_TESTING environment variable not > > set (or > > zero) > > t/taint.t .. ok > > > > "nobodz:nogrouq" should be "nobody:nogroup" > >

> > I think it's another issue here. Older version of Carp.pm used to > output a message without a trailing dot (i.e. "line 501"). Newer > Carp.pm versions output the message with a trailing dot (i.e. "line > 501."). So the real fix is to accept the trailing dot in the regexp. > > Regards, > Slaven

Appears to be same error as https://rt.cpan.org/Ticket/Display.html?id=77881.

Sat Jun 27 08:06:26 2015 jkeenan [...] cpan.org - Reference by ticket #77082 added

Fri Jul 24 18:25:46 2015 RICHE [...] cpan.org - Correspondence added

Show quoted text

> I think it's another issue here. Older version of Carp.pm used to > output a message without a trailing dot (i.e. "line 501"). Newer > Carp.pm versions output the message with a trailing dot (i.e. "line > 501."). So the real fix is to accept the trailing dot in the regexp. >

Can it be just as appropriate to require in Makefile.PL the Carp version where this was changed? The reason is changing the regex extends our own test matrix -- we would need to test with old and new Carp versions.

Fri Jul 24 18:39:20 2015 RICHE [...] cpan.org - Reference to ticket #77082 added

Fri Jul 24 18:40:32 2015 RICHE [...] cpan.org - Reference to ticket #77881 added

Fri Jul 24 18:45:52 2015 RICHE [...] cpan.org - Correspondence added

On Fri Jul 24 18:25:46 2015, RICHE wrote: Show quoted text

>

> > I think it's another issue here. Older version of Carp.pm used to > > output a message without a trailing dot (i.e. "line 501"). Newer > > Carp.pm versions output the message with a trailing dot (i.e. "line > > 501."). So the real fix is to accept the trailing dot in the regexp. > >

> > Can it be just as appropriate to require in Makefile.PL the Carp > version where this was changed? The reason is changing the regex > extends our own test matrix -- we would need to test with old and new > Carp versions.

Note that RJBS stated in IRC that this change occurred in Carp 1.25, but latest Carp is currently failing on Perl 5.6.x so we won't fix this just yet. Once fixed and generally agreed we can require 1.25+, then we can have a single regex. Note also the test fails for Debian 8.1 right now with error stating "getpwent() appears to be insane", so I'm not able to repro manually.

Wed Aug 05 15:53:17 2015 RICHE [...] cpan.org - Reference by ticket #106263 added

Sun Oct 11 08:21:03 2015 RICHE [...] cpan.org - Correspondence added

On Fri Jul 24 18:45:52 2015, RICHE wrote: Show quoted text

> On Fri Jul 24 18:25:46 2015, RICHE wrote:

> >

> > > I think it's another issue here. Older version of Carp.pm used to > > > output a message without a trailing dot (i.e. "line 501"). Newer > > > Carp.pm versions output the message with a trailing dot (i.e. "line > > > 501."). So the real fix is to accept the trailing dot in the > > > regexp. > > >

> > > > Can it be just as appropriate to require in Makefile.PL the Carp > > version where this was changed? The reason is changing the regex > > extends our own test matrix -- we would need to test with old and new > > Carp versions.

> > Note that RJBS stated in IRC that this change occurred in Carp 1.25, > but latest Carp is currently failing on Perl 5.6.x so we won't fix > this just yet. Once fixed and generally agreed we can require 1.25+, > then we can have a single regex. > > Note also the test fails for Debian 8.1 right now with error stating > "getpwent() appears to be insane", so I'm not able to repro manually.

Changed t/Path_root.t to be more liberal with the regular expression. https://github.com/rpcme/File-Path/commit/7875d2916ccc8be07459696d59afb5e905bd366b https://github.com/rpcme/File-Path/commit/f4a2145bb6e3dcd6da60e00d71b154324e85c32a

Sun Oct 11 08:21:04 2015 RICHE [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Mar 08 11:18:07 2017 jkeenan [...] cpan.org - Reference by ticket #120557 added