Skip Menu |

This queue is for tickets about the Net-Blogger CPAN distribution.

Report information
The Basics
Id: 8580
Status: resolved
Priority: 0/
Queue: Net-Blogger

People
Owner: claco [...] cpan.org
Requestors: stephen.hahn [...] sun.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.87
Fixed in: (no value)



Subject: Net::Blogger should support http_proxy environment file
(Net-Blogger-0.87 on Perl 5.8.4 on SunOS 5.10) It's nice for modules that use HTTP as a transport to use the $http_proxy convention. Here's a patch that does so: *** /home/sch/.cpan/build/Net-Blogger-0.87/lib/Net/Blogger/Engine/Base.pm Tue Feb 10 07:55:45 2004 --- /home/sch/lib/perl5/Net/Blogger/Engine/Base.pm Tue Nov 23 13:58:21 2004 *************** *** 225,231 **** || Error->throw(-text=>$!); $client->on_fault(\&_ClientFault); ! $client->proxy($self->Proxy); $client->uri($self->Uri()); # Fix this. --- 225,238 ---- || Error->throw(-text=>$!); $client->on_fault(\&_ClientFault); ! ! # Obey $http_proxy, if set. ! if (defined($ENV{http_proxy})) { ! $client->proxy($self->Proxy, proxy => ['http' => $ENV{http_proxy} ]); ! } else { ! $client->proxy($self->Proxy); ! } ! $client->uri($self->Uri()); # Fix this.
Thanks - I will add this shortly. Sorry for the delay :-) [guest - Tue Nov 23 18:01:29 2004]: Show quoted text
> (Net-Blogger-0.87 on Perl 5.8.4 on SunOS 5.10) > > It's nice for modules that use HTTP as a transport to use the > $http_proxy > convention. Here's a patch that does so: > > *** /home/sch/.cpan/build/Net-Blogger- > 0.87/lib/Net/Blogger/Engine/Base.pm Tue Feb 10 07:55:45 2004 > --- /home/sch/lib/perl5/Net/Blogger/Engine/Base.pm Tue Nov 23 > 13:58:21 2004 > *************** > *** 225,231 **** > || Error->throw(-text=>$!); > > $client->on_fault(\&_ClientFault); > ! $client->proxy($self->Proxy); > $client->uri($self->Uri()); > > # Fix this. > --- 225,238 ---- > || Error->throw(-text=>$!); > > $client->on_fault(\&_ClientFault); > ! > ! # Obey $http_proxy, if set. > ! if (defined($ENV{http_proxy})) { > ! $client->proxy($self->Proxy, proxy => ['http' => > $ENV{http_proxy} ]); > ! } else { > ! $client->proxy($self->Proxy); > ! } > ! > $client->uri($self->Uri()); > > # Fix this.
Support for http_proxy ENV variables was added in 1.0 by ASCOPE.