Subject: | Self-test failure: incorrect CAPI version-comparison |
Date: | Wed, 29 May 2013 22:07:57 -0400 |
To: | bug-Geo-IP [...] rt.cpan.org |
From: | "Daniel Macks" <dmacks [...] netspace.org> |
Building Geo-IP-1.41 on OS X 10.6 with Apple's perl-5.10.0 against a manually installed libgeoip (version 1.5.1), the self-test suite fails:
t/20_min_capi_version.t .. 1/1 # Test 1 got: "1.5.1" (t/20_min_capi_version.t at line 21)
# Expected: "1.5.0" (CAPI must be at least 1.5.0 - Please update libGeoIP)
# t/20_min_capi_version.t line 21 is: ok( $capi_version, "1.5.0", "CAPI must be at least 1.5.0 - Please update libGeoIP" );
t/20_min_capi_version.t .. Failed 1/1 subtests
"1.5.1" is not "at least 1.5.0"? The bug is in the test itself:
ok( $capi_version, "1.5.0", "CAPI must be at least 1.5.0 - Please update libGeoIP" );
but ok() tests for the two strings being equal, not a v-string being greater-or-equal.
dan
--
Daniel Macks
dmacks@netspace.org