Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Geo-IP CPAN distribution.

Report information
The Basics
Id: 85718
Status: resolved
Priority: 0/
Queue: Geo-IP

People
Owner: Nobody in particular
Requestors: dmacks [...] netspace.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.42



Subject: Self-test failure: incorrect CAPI version-comparison
Date: Wed, 29 May 2013 22:07:57 -0400
To: bug-Geo-IP [...] rt.cpan.org
From: "Daniel Macks" <dmacks [...] netspace.org>
Building Geo-IP-1.41 on OS X 10.6 with Apple's perl-5.10.0 against a manually installed libgeoip (version 1.5.1), the self-test suite fails: t/20_min_capi_version.t .. 1/1 # Test 1 got: "1.5.1" (t/20_min_capi_version.t at line 21) #   Expected: "1.5.0" (CAPI must be at least 1.5.0 - Please update libGeoIP) #  t/20_min_capi_version.t line 21 is:   ok( $capi_version, "1.5.0", "CAPI must be at least 1.5.0 - Please update libGeoIP" ); t/20_min_capi_version.t .. Failed 1/1 subtests "1.5.1" is not "at least 1.5.0"? The bug is in the test itself: ok( $capi_version, "1.5.0", "CAPI must be at least 1.5.0 - Please update libGeoIP" ); but ok() tests for the two strings being equal, not a v-string being greater-or-equal. dan -- Daniel Macks dmacks@netspace.org
Subject: Re: [rt.cpan.org #85718] Self-test failure: incorrect CAPI version-comparison
Date: Thu, 30 May 2013 12:47:44 +0200
To: bug-Geo-IP [...] rt.cpan.org
From: Boris Zentner <bzm [...] 2bz.de>
Hi Dan, yes, I'll fix. it should be ok( $capi_version, qr/1\.5\./, "CAPI must be at least 1.5.0 - Please update libGeoIP" ); Have a nice day -- Boris Zentner Am 30.05.2013 um 04:08 schrieb "dmacks@netspace.org via RT" <bug-Geo-IP@rt.cpan.org>: Show quoted text
> Wed May 29 22:08:31 2013: Request 85718 was acted upon. > Transaction: Ticket created by dmacks@netspace.org > Queue: Geo-IP > Subject: Self-test failure: incorrect CAPI version-comparison > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dmacks@netspace.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85718 > > > > Building Geo-IP-1.41 on OS X 10.6 with Apple's perl-5.10.0 against a manually installed libgeoip (version 1.5.1), the self-test suite fails: > > t/20_min_capi_version.t .. 1/1 # Test 1 got: "1.5.1" (t/20_min_capi_version.t at line 21) > # Expected: "1.5.0" (CAPI must be at least 1.5.0 - Please update libGeoIP) > # t/20_min_capi_version.t line 21 is: ok( $capi_version, "1.5.0", "CAPI must be at least 1.5.0 - Please update libGeoIP" ); > t/20_min_capi_version.t .. Failed 1/1 subtests > > "1.5.1" is not "at least 1.5.0"? The bug is in the test itself: > > ok( $capi_version, "1.5.0", "CAPI must be at least 1.5.0 - Please update libGeoIP" ); > > but ok() tests for the two strings being equal, not a v-string being greater-or-equal. > > dan > > -- > Daniel Macks > dmacks@netspace.org > >
Thanks for the report. This was fixed in 1.42.