Bug #85586 for Net-Server: Users and Groups with a period in their name throw a fatal error

Thu May 23 17:01:03 2013 patrick.mcanneny [...] leadkarma.com - Ticket created

Subject:	Users and Groups with a period in their name throw a fatal error
Date:	Thu, 23 May 2013 17:00:45 -0400
To:	bug-Net-Server [...] rt.cpan.org
From:	Patrick McAnneny <patrick.mcanneny [...] leadkarma.com>

The regular expressions at lines 344 and 354 in Net::Server::post_bind cause users and groups with periods in them to throw a fatal error even though they should be valid. Simply changing these two regular expressions fixes this. Possible solutions: ($prop->{'group'} =~ /^([\w-\.]+(?: [\w-\.]+)*)$/) ($prop->{'user'} =~ /^([\w-\.]+)$/) Thanks!

Thu Oct 30 10:56:32 2014 SREZIC [...] cpan.org - Correspondence added

On 2013-05-23 17:01:03, patrick.mcanneny@leadkarma.com wrote: Show quoted text

> The regular expressions at lines 344 and 354 in Net::Server::post_bind > cause users and groups with periods in them to throw a fatal error even > though they should be valid. > > Simply changing these two regular expressions fixes this. > > Possible solutions: > ($prop->{'group'} =~ /^([\w-\.]+(?: [\w-\.]+)*)$/) > ($prop->{'user'} =~ /^([\w-\.]+)$/)

I found this also problematic. An even better solution is to skip the check completely here, and pass $prop->{user} to get_uid and let this function decide if the user exists or not. So instead of } elsif ($prop->{'user'} =~ /^([\w-]+)$/) { $prop->{'user'} = eval { get_uid($1) }; $self->fatal(my $e = $@) if $@; } else { $self->fatal("Invalid user \"$prop->{'user'}\""); } it could be: } else { $prop->{'user'} = eval { get_uid($prop->{'user'}) }; $self->fatal(my $e = $@) if $@; } or (with a different error message): } else { $prop->{'user'} = eval { get_uid($prop->{'user'}) }; $self->fatal("Invalid user \"$prop->{'user'}\", error: $@") if $@; }

Thu Oct 30 10:56:33 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Dec 05 06:49:13 2014 SREZIC [...] cpan.org - Correspondence added

On 2014-10-30 10:56:32, SREZIC wrote: Show quoted text

> On 2013-05-23 17:01:03, patrick.mcanneny@leadkarma.com wrote:

> > The regular expressions at lines 344 and 354 in > > Net::Server::post_bind > > cause users and groups with periods in them to throw a fatal error > > even > > though they should be valid. > > > > Simply changing these two regular expressions fixes this. > > > > Possible solutions: > > ($prop->{'group'} =~ /^([\w-\.]+(?: [\w-\.]+)*)$/) > > ($prop->{'user'} =~ /^([\w-\.]+)$/)

> > I found this also problematic. > > An even better solution is to skip the check completely here, and pass > $prop->{user} to get_uid and let this function decide if the user > exists or not. So instead of > > } elsif ($prop->{'user'} =~ /^([\w-]+)$/) { > $prop->{'user'} = eval { get_uid($1) }; > $self->fatal(my $e = $@) if $@; > } else { > $self->fatal("Invalid user \"$prop->{'user'}\""); > } > > it could be: > > } else { > $prop->{'user'} = eval { get_uid($prop->{'user'}) }; > $self->fatal(my $e = $@) if $@; > } > > or (with a different error message): > > } else { > $prop->{'user'} = eval { get_uid($prop->{'user'}) }; > $self->fatal("Invalid user \"$prop->{'user'}\", error: $@") if $@; > }

A patch is available in http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/Net-Server-2.008-RT85586.patch CPAN.pm users may use this distropref file for automatic inclusion of this patch: https://github.com/eserte/srezic-cpan-distroprefs/blob/master/Net-Server.yml

Mon Nov 05 11:53:03 2018 SREZIC [...] cpan.org - Correspondence added

On 2014-12-05 06:49:13, SREZIC wrote: Show quoted text

> On 2014-10-30 10:56:32, SREZIC wrote:

> > On 2013-05-23 17:01:03, patrick.mcanneny@leadkarma.com wrote:

> > > The regular expressions at lines 344 and 354 in > > > Net::Server::post_bind > > > cause users and groups with periods in them to throw a fatal error > > > even > > > though they should be valid. > > > > > > Simply changing these two regular expressions fixes this. > > > > > > Possible solutions: > > > ($prop->{'group'} =~ /^([\w-\.]+(?: [\w-\.]+)*)$/) > > > ($prop->{'user'} =~ /^([\w-\.]+)$/)

> > > > I found this also problematic. > > > > An even better solution is to skip the check completely here, and > > pass > > $prop->{user} to get_uid and let this function decide if the user > > exists or not. So instead of > > > > } elsif ($prop->{'user'} =~ /^([\w-]+)$/) { > > $prop->{'user'} = eval { get_uid($1) }; > > $self->fatal(my $e = $@) if $@; > > } else { > > $self->fatal("Invalid user \"$prop->{'user'}\""); > > } > > > > it could be: > > > > } else { > > $prop->{'user'} = eval { get_uid($prop->{'user'}) }; > > $self->fatal(my $e = $@) if $@; > > } > > > > or (with a different error message): > > > > } else { > > $prop->{'user'} = eval { get_uid($prop->{'user'}) }; > > $self->fatal("Invalid user \"$prop->{'user'}\", error: $@") if > > $@; > > }

> > A patch is available in > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/Net-Server- > 2.008-RT85586.patch > > CPAN.pm users may use this distropref file for automatic inclusion of > this patch: > https://github.com/eserte/srezic-cpan-distroprefs/blob/master/Net- > Server.yml

This patch also works with 2.009.

Mon Nov 05 11:53:15 2018 SREZIC [...] cpan.org - Broken in 2.008 added

Mon Nov 05 11:53:15 2018 SREZIC [...] cpan.org - Broken in 2.009 added