Bug #85470 for Test-Deep-UnorderedPairs: Disallows repetition within the "keys"

Mon May 20 12:36:35 2013 perl [...] toby.ink - Ticket created

While Test-Deep-UnorderedPairs seems like it would be useful for some purposes, I'm not sure it would always be useful for the example given in the SYNOPSIS - comparing PSGI responses. The reason being that PSGI header arrayrefs allow repetition: [ Set_Cookie => q[foo='1'; path="/"], Set_Cookie => q[bar='2'; path="/"], ]

Mon May 20 12:37:40 2013 perl [...] toby.ink - Subject changed from (no value) to 'Disallows repetition within the "keys"'

Mon May 20 12:37:50 2013 perl [...] toby.ink - Severity Wishlist added

Mon May 20 12:38:36 2013 perl [...] toby.ink - Correspondence added

Perhaps an additional function could be provided that allowed repeated keys.

Mon May 20 12:42:29 2013 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #85470] Disallows repetition within the "keys"
Date:	Mon, 20 May 2013 09:42:15 -0700
To:	Toby Inkster via RT <bug-Test-Deep-UnorderedPairs [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Mon, May 20, 2013 at 12:38:36PM -0400, Toby Inkster via RT wrote: Show quoted text

> Queue: Test-Deep-UnorderedPairs > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85470 > > > Perhaps an additional function could be provided that allowed repeated keys.

Agreed, the current implementation would only work if there are no duplicate keys. I'll leave this ticket open while I ponder how to implement what is quite a valid usecase.

Mon May 20 12:42:30 2013 The RT System itself - Status changed from 'new' to 'open'

Mon May 20 17:16:05 2013 perl [...] toby.ink - Correspondence added

The easiest implementation I can see would be to map: [ foo => 3, foo => 2, bar => 1, ] to: [ foo => [3, 2], bar => [1], ] then sort those arrayrefs: [ foo => [2, 3], bar => [1], ] ... and you should be able to do a normal deep comparison.

Mon May 20 18:40:46 2013 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #85470] Disallows repetition within the "keys"
Date:	Mon, 20 May 2013 15:40:26 -0700
To:	Toby Inkster via RT <bug-Test-Deep-UnorderedPairs [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Mon, May 20, 2013 at 05:16:05PM -0400, Toby Inkster via RT wrote: Show quoted text

> then sort those arrayrefs: > > [ > foo => [2, 3], > bar => [1], > ] > > ... and you should be able to do a normal deep comparison.

Doing the comparisons is not difficult - one can even do the comparison like all(bag(pair), bag(pair), ...) -- the trick is getting the diagnostics to look sane on failure. That's why a custom descender is needed.

Tue May 21 02:07:23 2013 ether [...] cpan.org - Correspondence added

Fixed in v0.003.

Tue May 21 02:07:24 2013 ether [...] cpan.org - Status changed from 'open' to 'resolved'