Skip Menu |

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 85417
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: Nobody in particular
Requestors: victor [...] vsespb.ru
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.54
Fixed in: (no value)



Looks like code below will treat $content eq '0' as empty? sub do_httpx3 { my ($method, $usessl, $site, $port, $path, $headers, $content, $mime_type, $crt_path, $key_path) = @_; my ($response, $page, $h,$v); if ($content) { $mime_type = "application/x-www-form-urlencoded" unless $mime_type; my $len = blength($content); $content = "Content-Type: $mime_type$CRLF" . "Content-Length: $len$CRLF$CRLF$content"; } else { $content = "$CRLF$CRLF"; }
Subject: Re: [rt.cpan.org #85417]
Date: Sun, 19 May 2013 07:24:07 +0800
To: "bug-Net-SSLeay [...] rt.cpan.org" <bug-Net-SSLeay [...] rt.cpan.org>
From: Mike McCauley <mikem [...] airspayce.com>
Sent from my iPhone On 19/05/2013, at 2:59 AM, "Victor Efimov via RT" <bug-Net-SSLeay@rt.cpan.org> wrote: Show quoted text
> Sat May 18 14:59:36 2013: Request 85417 was acted upon. > Transaction: Ticket created by vsespb > Queue: Net-SSLeay > Subject: (No subject given) > Broken in: 1.54 > Severity: (no value) > Owner: Nobody > Requestors: victor@vsespb.ru > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85417 > > > > Looks like code below will treat $content eq '0' as empty?
Yes I expect so. Is it causing a problem? Cheers. Show quoted text
> > sub do_httpx3 { > my ($method, $usessl, $site, $port, $path, $headers, > $content, $mime_type, $crt_path, $key_path) = @_; > my ($response, $page, $h,$v); > > if ($content) { > $mime_type = "application/x-www-form-urlencoded" unless $mime_type; > my $len = blength($content); > $content = "Content-Type: $mime_type$CRLF" > . "Content-Length: $len$CRLF$CRLF$content"; > } else { > $content = "$CRLF$CRLF"; > } >
From: victor [...] vsespb.ru
Yes, I am thinking one can try to use post_http/post_https, say, to upload files and try to upload file with a single byte '0'. In that case it will upload $CRLF$CRLF instead. On Sun May 19 03:25:58 2013, mikem@airspayce.com wrote: Show quoted text
> > > Sent from my iPhone > > On 19/05/2013, at 2:59 AM, "Victor Efimov via RT" <bug-Net- > SSLeay@rt.cpan.org> wrote: >
> > Sat May 18 14:59:36 2013: Request 85417 was acted upon. > > Transaction: Ticket created by vsespb > > Queue: Net-SSLeay > > Subject: (No subject given) > > Broken in: 1.54 > > Severity: (no value) > > Owner: Nobody > > Requestors: victor@vsespb.ru > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85417 > > > > > > > Looks like code below will treat $content eq '0' as empty?
> > Yes I expect so. Is it causing a problem? > > Cheers. > >
> > > > sub do_httpx3 { > > my ($method, $usessl, $site, $port, $path, $headers, > > $content, $mime_type, $crt_path, $key_path) = @_; > > my ($response, $page, $h,$v); > > > > if ($content) { > > $mime_type = "application/x-www-form-urlencoded" unless
> $mime_type;
> > my $len = blength($content); > > $content = "Content-Type: $mime_type$CRLF" > > . "Content-Length: $len$CRLF$CRLF$content"; > > } else { > > $content = "$CRLF$CRLF"; > > } > >
Subject: Re: [rt.cpan.org #85417]
Date: Mon, 20 May 2013 16:39:57 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Hi again, thanks for reporting this. It should now be fixed in SVN. Cheers. On Saturday, May 18, 2013 07:55:12 PM Victor Efimov via RT wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85417 > > > Yes, I am thinking one can try to use post_http/post_https, say, to upload > files and try to upload file with a single byte '0'. In that case it will > upload $CRLF$CRLF instead. > On Sun May 19 03:25:58 2013, mikem@airspayce.com wrote:
> > Sent from my iPhone > > > > On 19/05/2013, at 2:59 AM, "Victor Efimov via RT" <bug-Net- > > > > SSLeay@rt.cpan.org> wrote:
> > > Sat May 18 14:59:36 2013: Request 85417 was acted upon. > > > Transaction: Ticket created by vsespb > > > > > > Queue: Net-SSLeay > > > > > > Subject: (No subject given) > > > > > > Broken in: 1.54 > > > > > > Severity: (no value) > > > > > > Owner: Nobody > > > > > > Requestors: victor@vsespb.ru > > > > > > Status: new > > > > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85417 > > > > > > > > > > Looks like code below will treat $content eq '0' as empty?
> > > > Yes I expect so. Is it causing a problem? > > > > Cheers. > >
> > > sub do_httpx3 { > > > > > > my ($method, $usessl, $site, $port, $path, $headers, > > > $content, $mime_type, $crt_path, $key_path) = @_; > > > my ($response, $page, $h,$v); > > > > > > if ($content) { > > > $mime_type = "application/x-www-form-urlencoded" unless
> > > > $mime_type; > >
> > > my $len = blength($content); > > > $content = "Content-Type: $mime_type$CRLF" > > > > > > . "Content-Length: $len$CRLF$CRLF$content"; > > > > > > } else { > > > $content = "$CRLF$CRLF"; > > > }
-- Mike McCauley mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474 Fax +61 7 5598-7070
From: dsteinbrunner [...] pobox.com
On Mon May 20 02:40:12 2013, mikem@airspayce.com wrote: Show quoted text
> thanks for reporting this. It should now be fixed in SVN.
Should this ticket be closed now?
From: victor [...] vsespb.ru
Thanks! Personally I don't mind closing this as it looks fixed. On Mon Jun 24 01:33:53 2013, dsteinbrunner@pobox.com wrote: Show quoted text
> On Mon May 20 02:40:12 2013, mikem@airspayce.com wrote: >
> > thanks for reporting this. It should now be fixed in SVN.
> > Should this ticket be closed now?