Bug #85406 for ExtUtils-MakeMaker: can't figure out how to get "repository":{"url":..., "web":..., "type": ...} into META.json

Sat May 18 00:52:12 2013 MAUKE [...] cpan.org - Ticket created

Subject:

can't figure out how to get "repository":{"url":..., "web":..., "type": ...} into META.json

According to https://metacpan.org/module/CPAN::Meta::Spec#resources there is a "repository" key with "url"/"web"/"type" subkeys. I can't figure out how to make EU:MM generate that. If it's just not possible, I'd consider that a problem with EU:MM. If it is possible, this is a documentation bug because as far as I can tell there's no documentation for it. I tried META_MERGE => { resources => { repository => { url => '...', web => '...', type => '...', }, }, }, but that seems to be silently ignored.

Wed May 29 01:36:39 2013 tsibley [...] cpan.org - Correspondence added

On Sat May 18 00:52:12 2013, MAUKE wrote: Show quoted text

> I tried > > META_MERGE => { > resources => { > repository => { > url => '...', > web => '...', > type => '...', > }, > }, > }, > > but that seems to be silently ignored.

I ran into a similar problem tonight with resources.bugtracker. The problem appears to be that ExtUtils::MM_Any generates a spec version 1.4 meta file by default. In that version of the spec, resources.repository and bugtracker are not a hashref but single URLs. It wasn't until version 2 of the meta spec that they became hashes. See https://metacpan.org/module/CPAN::Meta::History. To use the v2 form, also add: "meta-spec" => { version => 2 }, to your META_MERGE.

Wed May 29 01:36:40 2013 The RT System itself - Status changed from 'new' to 'open'

Wed May 29 01:36:55 2013 tsibley [...] cpan.org - Requestor TSIBLEY added

Wed May 29 23:05:06 2013 tsibley [...] cpan.org - Requestor TSIBLEY deleted

Wed May 29 23:05:06 2013 tsibley [...] cpan.org - Cc TSIBLEY added

Wed Jun 05 17:18:12 2013 chris [...] bingosnet.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #85406] can't figure out how to get "repository":{"url":..., "web":..., "type": ...} into META.json
Date:	Wed, 5 Jun 2013 22:17:51 +0100
To:	Thomas Sibley via RT <bug-ExtUtils-MakeMaker [...] rt.cpan.org>
From:	"Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>

On Wed, May 29, 2013 at 01:36:40AM -0400, Thomas Sibley via RT wrote: Show quoted text

> Queue: ExtUtils-MakeMaker > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85406 > > > On Sat May 18 00:52:12 2013, MAUKE wrote:

> > I tried > > > > META_MERGE => { > > resources => { > > repository => { > > url => '...', > > web => '...', > > type => '...', > > }, > > }, > > }, > > > > but that seems to be silently ignored.

> > I ran into a similar problem tonight with resources.bugtracker. The problem appears to be that ExtUtils::MM_Any generates a spec version 1.4 meta file by default. In that version of the spec, resources.repository and bugtracker are not a hashref but single URLs. It wasn't until version 2 of the meta spec that they became hashes. See https://metacpan.org/module/CPAN::Meta::History. > > To use the v2 form, also add: > > "meta-spec" => { version => 2 }, > > to your META_MERGE.

I've documented this under META_MERGE in ExtUtils::MakeMaker documentation now. Many thanks, -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sat Jun 08 17:54:48 2013 MAUKE [...] cpan.org - Correspondence added

On Wed May 29 01:36:39 2013, TSIBLEY wrote: Show quoted text

> > To use the v2 form, also add: > > "meta-spec" => { version => 2 }, > > to your META_MERGE.

That breaks everything. More specifically, I did that and found that the resulting MYMETA.{json,yml} files lacked all prerequisites, i.e. all of CONFIGURE_REQUIRES/BUILD_REQUIRES/TEST_REQUIRES/PREREQ_PM in my Makefile.PL were silently removed.

Sat Jun 08 18:22:09 2013 MAUKE [...] cpan.org - Correspondence added

On Sat Jun 08 17:54:48 2013, MAUKE wrote: Show quoted text

> On Wed May 29 01:36:39 2013, TSIBLEY wrote:

> > > > To use the v2 form, also add: > > > > "meta-spec" => { version => 2 }, > > > > to your META_MERGE.

> > That breaks everything. More specifically, I did that and found that > the resulting MYMETA.{json,yml} files lacked all prerequisites, > i.e. all of > CONFIGURE_REQUIRES/BUILD_REQUIRES/TEST_REQUIRES/PREREQ_PM in my > Makefile.PL were silently removed.

I'm not sure what's going on but things are getting dropped by CPAN::Meta::Converter->convert (calling _convert). The code seems to be expecting a key called "prereqs" but it's getting "requires" instead, which it drops.

Sat Jun 08 19:53:45 2013 MAUKE [...] cpan.org - Correspondence added

On Sat Jun 08 18:22:09 2013, MAUKE wrote: Show quoted text

> On Sat Jun 08 17:54:48 2013, MAUKE wrote:

> > On Wed May 29 01:36:39 2013, TSIBLEY wrote:

> > > > > > To use the v2 form, also add: > > > > > > "meta-spec" => { version => 2 }, > > > > > > to your META_MERGE.

> > > > That breaks everything. More specifically, I did that and found that > > the resulting MYMETA.{json,yml} files lacked all prerequisites, > > i.e. all of > > CONFIGURE_REQUIRES/BUILD_REQUIRES/TEST_REQUIRES/PREREQ_PM in my > > Makefile.PL were silently removed.

> > I'm not sure what's going on but things are getting dropped by > CPAN::Meta::Converter->convert (calling _convert). The code seems > to be expecting a key called "prereqs" but it's getting "requires" > instead, which it drops.

I found a workaround. In addition to 'META_MERGE => {'meta-spec' => {version => 2}}', I added the following to Makefile.PL: # Why? For the glory of satan, of course! { no warnings qw(redefine); *ExtUtils::MM_Any::_add_requirements_to_meta_v1_4 = \&ExtUtils::MM_Any::_add_requirements_to_meta_v2; } That seems to "fix" everything.

Sun Jun 09 02:46:49 2013 ribasushi [...] leporine.io - Cc RIBASUSHI added

Mon Jun 10 15:26:56 2013 chris [...] bingosnet.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #85406] can't figure out how to get "repository":{"url":..., "web":..., "type": ...} into META.json
Date:	Mon, 10 Jun 2013 20:26:37 +0100
To:	Lukas Mai via RT <bug-ExtUtils-MakeMaker [...] rt.cpan.org>
From:	"Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>

On Sat, Jun 08, 2013 at 07:53:45PM -0400, Lukas Mai via RT wrote: Show quoted text

> Queue: ExtUtils-MakeMaker > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85406 > > > On Sat Jun 08 18:22:09 2013, MAUKE wrote:

> > On Sat Jun 08 17:54:48 2013, MAUKE wrote:

> > > On Wed May 29 01:36:39 2013, TSIBLEY wrote:

> > > > > > > > To use the v2 form, also add: > > > > > > > > "meta-spec" => { version => 2 }, > > > > > > > > to your META_MERGE.

> > > > > > That breaks everything. More specifically, I did that and found that > > > the resulting MYMETA.{json,yml} files lacked all prerequisites, > > > i.e. all of > > > CONFIGURE_REQUIRES/BUILD_REQUIRES/TEST_REQUIRES/PREREQ_PM in my > > > Makefile.PL were silently removed.

> > > > I'm not sure what's going on but things are getting dropped by > > CPAN::Meta::Converter->convert (calling _convert). The code seems > > to be expecting a key called "prereqs" but it's getting "requires" > > instead, which it drops.

> > I found a workaround. In addition to 'META_MERGE => {'meta-spec' => {version => 2}}', I added the following to Makefile.PL: > > # Why? For the glory of satan, of course! > { > no warnings qw(redefine); > *ExtUtils::MM_Any::_add_requirements_to_meta_v1_4 = \&ExtUtils::MM_Any::_add_requirements_to_meta_v2; > } > > That seems to "fix" everything.

v6.67_04 uploaded to CPAN which doesn't require this hackery. -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Fri Jun 14 18:52:45 2013 BINGOS [...] cpan.org - Correspondence added

This has been resolved by the 6.68 release. Many thanks.

Fri Jun 14 18:52:46 2013 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jun 14 18:52:46 2013 BINGOS [...] cpan.org - Fixed in 6.67_04 added