Bug #85315 for Bot-Pastebot: Advertised version comes from configuration file and is not updated on updates

Wed May 15 09:03:41 2013 abe [...] deuxchevaux.org - Ticket created

Subject:	Advertised version comes from configuration file and is not updated on updates
Date:	Wed, 15 May 2013 15:03:20 +0200
To:	bug-Bot-Pastebot [...] rt.cpan.org
From:	Axel Beckert <abe [...] deuxchevaux.org>

Hi, I just updated our instance of Bot::Pastebot from 0.51 to 0.543. But "/ctcp version" still yielded "Bot::Pastebot/0.51" which confused me a lot. It was still there after I've removed all possible traces of the 0.51 installation. Then I finally noticed that the version string comes from /etc/pastebot.conf and even seems mandatory, because if I remove it, pastebot argues "conf error: section `irc' requires item `cver' at /etc/pastebot.conf line 10". I would have expected that the version returned by the IRC bot reflects the running version of Bot::Pastebot and is not an arbitrary string by default. It's nice that the string is settable by the administrator, but IMHO it should be telling the real version by default, i.e. it should not come from the local configuration file by default. Additionally I'd have expected to find some $VERSION variable somewhere in the module, so that e.g. pmvers from the pntools distribution would show it. Currently it doesn't: # pmvers Bot::Pastebot /usr/bin/pmvers: unknown version for module `Bot::Pastebot' Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail) X See http://www.asciiribbon.org/ | abe@noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Sat Jul 13 04:12:30 2013 RCAPUTO [...] cpan.org - Correspondence added

Hi, Axel. The user-specified version string is an old standard IRC feature. It goes back to times when people would try to exploit your client based on what you were running. I'd like to keep it as a feature. What do you think about cver being optional and defaulting it to the current Bot::Pastebot version?

Sat Jul 13 04:12:30 2013 The RT System itself - Status changed from 'new' to 'open'

Sat Jul 13 14:30:51 2013 RCAPUTO [...] cpan.org - Correspondence added

These changes should implement your suggestions. The move to Dist::Zilla covers the lack of $VERSION in modules. commit f7bfcf75c2d1fc664eb92224260e8d83b4f3b5a3 Author: Rocco Caputo <rcaputo@cpan.org> Date: Sat Jul 13 13:56:15 2013 -0400 Superficially document internal modules for Dist::Zilla's sake. commit 6f05b1d3890abdb2267035fc264f8f8d8675f65d Author: Rocco Caputo <rcaputo@cpan.org> Date: Sat Jul 13 13:55:47 2013 -0400 Initial conversion to Dist::Zilla. commit 72af32a73aa826b1440474f562e96589bb51efe6 Author: Rocco Caputo <rcaputo@cpan.org> Date: Sat Jul 13 13:55:06 2013 -0400 Add an example configuration for web pastebin-only use. commit 6472f72bbbca96ecd1d31aaafdbe908371b8f02e Author: Rocco Caputo <rcaputo@cpan.org> Date: Sat Jul 13 13:01:44 2013 -0400 [rt.cpan.org 85315] Make cver optional. Per Axel Beckert's recommendation, the IRC version string is made optinoal and will default to the module's current version info. cver can still be overridden in the .conf file, and all existing installations will continue to work the way they always have.

Sat Jul 13 14:30:52 2013 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'