Bug #85180 for Task-Perl-Critic: Please remove Perl::Critic::Nits

Fri May 10 14:19:34 2013 mschwern [...] cpan.org - Ticket created

Subject:

Please remove Perl::Critic::Nits

I would ask that Perl::Critic::Nits be removed from the Task. Perl::Critic::Nits contains only Perl::Critic::Policy::ValuesAndExpressions::ProhibitAccessOfPrivateData which gives tons and tons of false positives and is at the highest severity. Very annoying. It took me a while to realize it wasn't a new Perl::Critic policy and was installed by Task::Perl::Critic.

Fri May 10 14:52:58 2013 jeff [...] imaginative-software.com - Correspondence added

Subject:	Re: [rt.cpan.org #85180] Please remove Perl::Critic::Nits
Date:	Fri, 10 May 2013 11:52:38 -0700
To:	bug-Task-Perl-Critic [...] rt.cpan.org
From:	Jeffrey Ryan Thalhammer <jeff [...] imaginative-software.com>

Well, the whole point of Task::Perl::Critic is to bundle all the available Policy distributions. I agree that the severity is too high, given the false positives, and you can file a bug on Nits for that. But removing it from the Task doesn't seem like the right thing to do. -Jeff

Fri May 10 14:52:58 2013 The RT System itself - Status changed from 'new' to 'open'

Fri May 10 17:04:33 2013 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #85180] Please remove Perl::Critic::Nits
Date:	Fri, 10 May 2013 14:04:16 -0700
To:	bug-Task-Perl-Critic [...] rt.cpan.org
From:	"Michael G. Schwern" <schwern [...] pobox.com>

On 5/10/13 11:52 AM, Jeffrey Thalhammer via RT wrote: Show quoted text

> Well, the whole point of Task::Perl::Critic is to bundle > all the available Policy distributions.

I guess that's the stated goal. I'd find a little curation to be more useful. Maybe move the "install all the policies" task to Task::Perl::Critic::All? Show quoted text

> I agree that the severity is too high, given the false positives, > and you can file a bug on Nits for that.

I will do so.