Bug #85157 for Moose: Warnings when using with latest version of Package::Stash

Thu May 09 12:32:39 2013 pablo [...] pablo.com.mx - Ticket created

Subject:	Warnings when using with latest version of Package::Stash
Date:	Thu, 9 May 2013 09:32:24 -0700
To:	bug-Class-MOP [...] rt.cpan.org
From:	Pablo Fischer <pablo [...] pablo.com.mx>

Hello, One of the applications I've has a dependency in Moose, moose has a dependency on Class::MOP.. Class::MOP depends on Package::Stash 0.13 or higher. The latest version of Package::Stash (pushed to cpan on 04/Jan/2013 has a list of deprecated calls that are still in Class::MOP. Can Class::MOP::Package be fixed so it can work with newest version of Package::Stash (deprecated calls) and with the old one? Package::Stash::get_or_add_package_symbol('Package::Stash=HASH(0xa01aee0)', 'HASH(0xa01acc4)') called at perl/5.10/i686-linux-thread-multi-64int-ld/Class/MOP/Package.pm line 128 Class::MOP::Package::get_or_add_package_symbol('Class::MOP::Class=HASH(0xa01ad64)', 'HASH(0xa01acc4)') called at perl/5.10/i686-linux-thread-multi-64int-ld/Class/MOP/Class.pm line 836 From code of Package::Stash: http://cpansearch.perl.org/src/DOY/Package-Stash-0.34/lib/Package/Stash.pm sub get_or_add_package_symbol { deprecated('get_or_add_package_symbol is deprecated, please use get_or_add_symbol'); shift->get_or_add_symbol(@_); } Thanks! -- Pablo Fischer (pablo [arroba/at] pablo.com.mx)

Thu May 09 13:49:17 2013 ether [...] cpan.org - Correspondence added

On 2013-05-09 09:32:39, pablo@pablo.com.mx wrote: Show quoted text

> Hello, > > One of the applications I've has a dependency in Moose, moose has a > dependency on Class::MOP.. Class::MOP depends on Package::Stash 0.13 > or > higher. The latest version of Package::Stash (pushed to cpan on > 04/Jan/2013 > has a list of deprecated calls that are still in Class::MOP. > > Can Class::MOP::Package be fixed so it can work with newest version of > Package::Stash (deprecated calls) and with the old one?

Can you clarify the problem? Is it problematic for you to upgrade to the latest Package::Stash? Class::MOP is not calling any deprecated methods in Package::Stash. However, a quick grep of the codebase can appear as if it is, because some of the method names in Class::MOP::Package are the same as some of these deprecated methods in PS.

Thu May 09 13:49:18 2013 The RT System itself - Status changed from 'new' to 'open'

Thu May 09 13:49:44 2013 ether [...] cpan.org - Queue changed from Class-MOP to Moose

Thu May 09 13:53:59 2013 PFISCHER [...] cpan.org - Correspondence added

On Thu May 09 13:49:17 2013, ETHER wrote: Show quoted text

> On 2013-05-09 09:32:39, pablo@pablo.com.mx wrote:

> > Hello, > > > > One of the applications I've has a dependency in Moose, moose has a > > dependency on Class::MOP.. Class::MOP depends on Package::Stash 0.13 > > or > > higher. The latest version of Package::Stash (pushed to cpan on > > 04/Jan/2013 > > has a list of deprecated calls that are still in Class::MOP. > > > > Can Class::MOP::Package be fixed so it can work with newest version

> of

> > Package::Stash (deprecated calls) and with the old one?

> > Can you clarify the problem? Is it problematic for you to upgrade to > the latest Package::Stash?

Problem is with a _LOT_ of warnings and not sure if there would be a (bigger) potential problem with a future version of Package::Stash that totally removes these methods. Show quoted text

> > Class::MOP is not calling any deprecated methods in Package::Stash. > However, a quick grep of the codebase can appear as if it is, > because some of the method names in Class::MOP::Package are the > same as some of these deprecated methods in PS.

Yep, that's correct.

Thu May 09 13:57:24 2013 DOY [...] cpan.org - Correspondence added

Moose does not have a dependency on Class::MOP - Class::MOP was moved into the Moose distribution several years ago. The separate Class::MOP distribution on CPAN is historical and should not be used. The latest version of Moose depends on Package::Stash 0.32, and the Class::MOP that is shipped with the latest version of Moose does not contain any calls to deprecated methods in Package::Stash.

Thu May 09 13:57:24 2013 DOY [...] cpan.org - Status changed from 'open' to 'rejected'

Thu May 09 14:11:57 2013 PFISCHER [...] cpan.org - Correspondence added

On Thu May 09 13:57:24 2013, DOY wrote: Show quoted text

> Moose does not have a dependency on Class::MOP - Class::MOP was moved > into the Moose distribution several years ago. The separate > Class::MOP distribution on CPAN is historical and should not be > used. The latest version of Moose depends on Package::Stash 0.32, > and the Class::MOP that is shipped with the latest version of Moose > does not contain any calls to deprecated methods in Package::Stash.

I think that explains it =/ Just found out I had that old version that depends on Class-MOP =/. I'll need to upgrade (this is a veryyyyy old app, that's why)