Bug #85108 for HiPi: Test suite calls "apt-get update"

Tue May 07 04:44:45 2013 jason [...] ukfsn.org - Ticket created

Subject:

Test suite calls "apt-get update"

The test suite for your module fails as it calls "apt-get update". Please remove this from the tests. Your tests have no place whatsoever trying to do anything to the system databases.

Tue May 07 05:10:43 2013 mdootson [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #85108] Test suite calls "apt-get update"
Date:	Tue, 07 May 2013 10:09:40 +0100
To:	bug-HiPi [...] rt.cpan.org
From:	mdootson <mdootson [...] cpan.org>

Hi Jason On 07/05/2013 09:44, Jason Clifford via RT wrote: Show quoted text

> Tue May 07 04:44:45 2013: Request 85108 was acted upon. > Transaction: Ticket created by CLIFFORDJ > Queue: HiPi > Subject: Test suite calls "apt-get update" > Broken in: (no value) > Severity: Normal > Owner: Nobody > Requestors: jason@ukpost.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85108 > > > > The test suite for your module fails as it calls "apt-get update". > > Please remove this from the tests. Your tests have no place whatsoever trying to do anything to the system databases. >

The fact that the installation / build and test call apt-get update is covered several times in the documentation. It is a decision I made. If you don't like it - don't install or use the modules. Best Regards Mark

Tue May 07 05:10:43 2013 The RT System itself - Status changed from 'new' to 'open'

Tue May 07 05:22:08 2013 jason [...] ukpost.com - Correspondence added

Subject:	Re: [rt.cpan.org #85108] Test suite calls "apt-get update"
Date:	Tue, 7 May 2013 10:21:49 +0100
To:	bug-HiPi [...] rt.cpan.org
From:	Jason Clifford <jason [...] ukpost.com>

I appreciate that decisions on what to include in your module are yours however when you uploaded it to cpan you pushed it onto those of us who run the cpan automated test servers and it us causing those tests to get stuck because of the call to apt. Could you perhaps make that party of the tests dependent upon some environment setting? On May 7, 2013 10:10 AM, "Mark Dootson via RT" <bug-HiPi@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=85108 > > > Hi Jason > > On 07/05/2013 09:44, Jason Clifford via RT wrote:

> > Tue May 07 04:44:45 2013: Request 85108 was acted upon. > > Transaction: Ticket created by CLIFFORDJ > > Queue: HiPi > > Subject: Test suite calls "apt-get update" > > Broken in: (no value) > > Severity: Normal > > Owner: Nobody > > Requestors: jason@ukpost.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85108 > > > > > > > The test suite for your module fails as it calls "apt-get update". > > > > Please remove this from the tests. Your tests have no place whatsoever

> trying to do anything to the system databases.

> >

> > The fact that the installation / build and test call apt-get update is > covered several times in the documentation. It is a decision I made. If > you don't like it - don't install or use the modules. > > Best Regards > > Mark > > >

Tue May 07 05:32:50 2013 mdootson [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #85108] Test suite calls "apt-get update"
Date:	Tue, 07 May 2013 10:31:47 +0100
To:	bug-HiPi [...] rt.cpan.org
From:	mdootson <mdootson [...] cpan.org>

Hi, On 07/05/2013 10:22, jason@ukpost.com via RT wrote: Show quoted text

> Queue: HiPi > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85108 > > > I appreciate that decisions on what to include in your module are yours > however when you uploaded it to cpan you pushed it onto those of us who run > the cpan automated test servers and it us causing those tests to get stuck > because of the call to apt. > > Could you perhaps make that party of the tests dependent upon some > environment setting? > On May 7, 2013 10:10 AM, "Mark Dootson via RT" <bug-HiPi@rt.cpan.org> wrote:

Yes, I will fix the issue for the next release now that I understand your request. Explaining how my modules are causing you problems gives me something to fix when I agree there is an issue. I'll find a way of switching off any interaction with cpan testers if I can. Best Regards Mark

Wed Jun 12 18:41:43 2013 BlueT [...] BlueT.org - Correspondence added

It would be really nice if I (HiPi user) can choose to install those packages manually, or let HiPi installation script do it automatically. I was scared by those system commands at the first time installing HiPi. :-) 在 2013年5月7日周二下午05:32:50 時，MDOOTSON 寫到： Show quoted text

> Hi, > > On 07/05/2013 10:22, jason@ukpost.com via RT wrote:

> > Queue: HiPi > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85108 > > > > > I appreciate that decisions on what to include in your module are

> yours

> > however when you uploaded it to cpan you pushed it onto those of us

> who run

> > the cpan automated test servers and it us causing those tests to get

> stuck

> > because of the call to apt. > > > > Could you perhaps make that party of the tests dependent upon some > > environment setting? > > On May 7, 2013 10:10 AM, "Mark Dootson via RT" <bug-

> HiPi@rt.cpan.org> wrote: > > Yes, I will fix the issue for the next release now that I understand > your request. Explaining how my modules are causing you problems gives > me something to fix when I agree there is an issue. > > I'll find a way of switching off any interaction with cpan testers if > I can. > > > Best Regards > > Mark > > > >

Mon Jan 18 19:13:08 2016 tmurray.NO [...] MEAT.wumpus-cave.net - Correspondence added

I'd like to reiterate this ticket, as it's causing a build failure on Debian Jessie with a Pi2: Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: perl-modules : Breaks: libthread-queue-perl (< 3.05) E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages. failed installing dependencies: No such file or directory at inc/Module/Build/HiPi.pm line 156. I was able to meet this dependency by calling "cpanm Thread::Queue". I then disabled the packages from being installed by adding "@debs = ();" on line 150 of inc/Module/Build/HiPi.pm.

Tue Apr 05 08:55:09 2016 dolmen [...] cpan.org - Correspondence added

RT-Send-CC:

LEONT [...] cpan.org

Show quoted text

>
> The fact that the installation / build and test call apt-get update is
> covered several times in the documentation. It is a decision I made.
> If
> you don't like it - don't install or use the modules.
>
> Best Regards
>
> Mark

Build.PL must only declare the dependencies it needs and install the distribution itself.
It is out of its scope to:
- use sudo rights
- install dependencies
- upgrade the system database
For more information about what the CPAN toolchain expects from a Build.PL script:
https://github.com/Perl-Toolchain-Gang/cpan-api-buildpl/blob/master/lib/CPAN/API/BuildPL.pm

But if you want to provide this install automation to your users, it would be ok to provide this but as an other install script. Just don't name it with a name that is automatically used by CPAN clients. So don't use Build.PL or Makefile.PL.

--
Olivier Mengué - http://perlresume.org/DOLMEN

Tue Apr 05 14:27:30 2016 mdootson [...] cpan.org - Correspondence added

I'm not sure I agree about what I must and must not do or that you are the person to instruct me in the matter. In spite of this it does seem that you do actually have a good idea with regard to a separate install script. Thanks very much. On Tue Apr 05 08:55:09 2016, DOLMEN wrote: Show quoted text

> > > > The fact that the installation / build and test call apt-get update > > is > > covered several times in the documentation. It is a decision I made. > > If > > you don't like it - don't install or use the modules. > > > > Best Regards > > > > Mark

> > Build.PL must only declare the dependencies it needs and install the > distribution itself. > It is out of its scope to: > - use sudo rights > - install dependencies > - upgrade the system database > For more information about what the CPAN toolchain expects from a > Build.PL > script: > https://github.com/Perl-Toolchain-Gang/cpan-api- > buildpl/blob/master/lib/CPAN/API/BuildPL.pm > > > But if you want to provide this install automation to your users, it > would be > ok to provide this but as an other install script. Just don't name it > with a > name that is automatically used by CPAN clients. So don't use Build.PL > or > Makefile.PL. > > -- > Olivier Mengué - http://perlresume.org/DOLMEN

Wed Apr 06 00:19:14 2016 mdootson [...] cpan.org - Correspondence added

RT-Send-CC:

LEONT [...] cpan.org

These issues are fixed I think in version 0.49. Build.PL doesn't do any package dependency checking or installation now. That has been shifted into the optional automated install script. The automated install script also plays nice by prompting for confirmation before attempting to install anything. On Mon Jan 18 19:13:08 2016, TMURRAY wrote: Show quoted text

> I'd like to reiterate this ticket, as it's causing a build failure on > Debian Jessie with a Pi2: > > Some packages could not be installed. This may mean that you have > requested an impossible situation or if you are using the unstable > distribution that some required packages have not yet been created > or been moved out of Incoming. > The following information may help to resolve the situation: > > The following packages have unmet dependencies: > perl-modules : Breaks: libthread-queue-perl (< 3.05) > E: Error, pkgProblemResolver::Resolve generated breaks, this may be > caused by held packages. > failed installing dependencies: No such file or directory at > inc/Module/Build/HiPi.pm line 156. > > I was able to meet this dependency by calling "cpanm Thread::Queue". I > then disabled the packages from being installed by adding "@debs = > ();" on line 150 of inc/Module/Build/HiPi.pm.

Thu Mar 23 17:26:19 2017 mdootson [...] cpan.org - Correspondence added

Reasons for grief are completely removed from recent releases.

Thu Mar 23 17:26:25 2017 mdootson [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Mar 23 17:26:25 2017 mdootson [...] cpan.org - Taken

Thu Mar 23 17:26:25 2017 mdootson [...] cpan.org - Fixed in 0.63 added