Skip Menu |

This queue is for tickets about the HTTP-Cookies CPAN distribution.

Report information
The Basics
Id: 85011
Status: resolved
Priority: 0/
Queue: HTTP-Cookies
People
Owner: Nobody in particular
Requestors: lxp [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 6.01
Fixed in: (no value)

History Show all quoted text
  Fri May 03 01:45:55 2013 lxp [...] cpan.org - Ticket created
Subject: allow different "ignore_discard" value at save() time
In HTTP::Cookies v6.01, the "save" method only saves "Discard" cookies if the "ignore_discard" attribute was set to a true value at object construction. If that did not occur, then currently there is no way to cause "Discard" cookies to be written to file without breaking object encapsulation. This is a problem when code wishing to save the complete contents of a cookie jar does not have control over its creation. Please consider adding either: 1. an "ignore_discard" method to allow altering of this attribute after construction; or 2. a second, optional argument to the "save" method which allows overriding of the object-based "ignore_discard" attribute: $cookie_jar->save( $file, $ignore_discard )
  Fri May 03 01:54:33 2013 lxp [...] cpan.org - Correspondence added
On Fri May 03 15:45:55 2013, LXP wrote: Show quoted text
> Please consider adding either: > > 1. an "ignore_discard" method to allow altering of this attribute after > construction; or > > 2. a second, optional argument to the "save" method which allows > overriding of the object-based "ignore_discard" attribute: > > $cookie_jar->save( $file, $ignore_discard )
After further thought, I think I would personally prefer option #2 since it doesn't alter object state (and therefore won't cause unintended side effects no possible later calls to "save"). Both options are backwards-compatible with the current API, however.
  Fri May 03 01:55:22 2013 lxp [...] cpan.org - Correspondence added
On Fri May 03 15:54:33 2013, LXP wrote: Show quoted text
> After further thought, I think I would personally prefer option #2 since > it doesn't alter object state (and therefore won't cause unintended side > effects no possible later calls to "save").
...effects on* possible later calls to "save."
  Fri May 03 02:32:07 2013 lxp [...] cpan.org - Correspondence added
A test and patch for this functionality (implemented as an additional save() argument) is available here: https://github.com/gisle/http-cookies/pull/2
  Fri May 03 02:32:07 2013 lxp [...] cpan.org - Subject changed from 'allow different "ignore_discard" value at save() time' to 'patch: allow different "ignore_discard" value at save() time'
  Fri May 03 02:32:07 2013 lxp [...] cpan.org - Reference to https://github.com/gisle/http-cookies/pull/2 added
  Thu Mar 30 19:30:24 2017 olaf [...] wundersolutions.com - Correspondence added
Ticket migrated to github as https://github.com/libwww-perl/http-cookies/issues/23
  Thu Mar 30 19:30:25 2017 The RT System itself - Status changed from 'new' to 'open'
  Thu Mar 30 19:30:30 2017 olaf [...] wundersolutions.com - Status changed from 'open' to 'resolved'