Bug #84915 for PathTools: File::Spec::Unix::catdir doesn't check for defined-ness

Mon Apr 29 04:38:14 2013 lxp [...] cpan.org - Ticket created

Subject:

File::Spec::Unix::catdir doesn't check for defined-ness

# expected: BOOM # actual: /file.txt File::Spec::Unix->catfile(undef, 'file.txt') No one in their right mind would explicitly pass undef to this function, especially since the behaviour in that situation isn't described in the File::Spec docs. Accidents do happen though (see [rt.cpan.org #84914]), and it would be handy if File::Spec made some noise in this situation so that the cause for failure is more obvious, not occurring at an unnecessary distance.

Mon Apr 29 15:22:28 2013 kwilliams [...] cpan.org - Correspondence added

I like it when functions like this throw an exception in case of bogus input. If we were to switch to doing that, would we need a "deprecation period" before making the change? Or does anyone want to argue that we shouldn't make the change?

Mon Apr 29 15:22:29 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 22 23:17:08 2013 lxp [...] cpan.org - Correspondence added

On Tue Apr 30 05:22:28 2013, KWILLIAMS wrote: Show quoted text

> I like it when functions like this throw an exception in case of > bogus input. If we were to switch to doing that, would we need a > "deprecation period" before making the change? Or does anyone want > to argue that we shouldn't make the change?

I'd say more than six months of silence is tacit approval from all relevant parties to make the change. ;) I'd also argue that a deprecation period isn't strictly necessary in this case, because it seems highly likely to me that anywhere that this is occurring in the wild, it's silently failing anyway.

Tue Nov 26 18:46:13 2013 jkeenan [...] cpan.org - Requestor JKEENAN added