Bug #84914 for File-ShareDir: _dist_file_new assumes _dist_dir

Sun Oct 19 00:25:12 2008 tokuhirom+cpan [...] gmail.com - Ticket #40158: Ticket created

Subject:

avoid warnings at -w mode

File::ShareDir cause some warnings. Because, - dist_dir_new returns undef if a module uses legacy path - if user uses -w, File::Spec shouts a lot of warnings :( === lib/File/ShareDir.pm ================================================================== --- lib/File/ShareDir.pm (revision 28048) +++ lib/File/ShareDir.pm (local) @@ -322,6 +322,7 @@ # If it exists, what should the path be my $dir = _dist_dir_new( $dist ); + return undef unless defined $dir; my $path = File::Spec->catfile( $dir, $file ); # Does the file exist

Fri Feb 13 04:35:16 2009 MIYAGAWA [...] cpan.org - Ticket #40158: Correspondence added

+1 to this patch. This warning made me write such a nasty patch like this to shut up warnings: http://coderepos.org/share/changeset/30013

Fri Feb 13 04:35:18 2009 The RT System itself - Ticket #40158: Status changed from 'new' to 'open'

Mon Apr 29 04:28:12 2013 lxp [...] cpan.org - Ticket created

Subject:

_dist_file_new assumes _dist_dir_new returns a defined value

When _dist_dir_new returns undef, _dist_file_new blindly passes that undef to File::Spec->catfile. The docs for "catfile" in File::Spec don't explicitly define what should occur in such a case, but on Unix at least, undef is treated as "" which leads to _dist_file_new looking for a file in the root directory. All well and good if the root directory doesn't actually contain a file with the same name as the desired one. If it does, however: File '/vmlinuz', no read permissions at ... line ... . A contrived example, but having a share-dir file named "vmlinuz" is perfectly legitimate! Given no explicitly defined behaviour on File::Spec's part for undefined values, it seems that File::ShareDir should be ensuring that it doesn't pass such values to it, particularly since File::ShareDir in the future may croak or something when it encounters undef ([rt.cpan.org #82754]). A patch correcting this behaviour is attached.

Subject:

0001-dont-pass-undef-to-File-Spec-catfile.patch

Index: lib/File/ShareDir.pm =================================================================== --- lib/File/ShareDir.pm (revision 15773) +++ lib/File/ShareDir.pm (working copy) @@ -323,7 +323,8 @@ my $file = shift; # If it exists, what should the path be - my $dir = _dist_dir_new( $dist ); + my $dir = _dist_dir_new( $dist ); + return undef unless defined $dir; my $path = File::Spec->catfile( $dir, $file ); # Does the file exist

Mon Apr 29 04:38:14 2013 lxp [...] cpan.org - Reference by ticket #84915 added

Mon Apr 29 04:41:05 2013 lxp [...] cpan.org - Correspondence added

On Mon Apr 29 18:28:12 2013, LXP wrote: Show quoted text

> Given no explicitly defined behaviour on File::Spec's part for undefined > values, it seems that File::ShareDir should be ensuring that it doesn't > pass such values to it, particularly since File::ShareDir in the future > may croak or something when it encounters undef ([rt.cpan.org #82754]).

Oops, wrong ticket. See [rt.cpan.org #84915] instead.

Mon Apr 29 04:41:06 2013 lxp [...] cpan.org - Reference to ticket #82754 deleted

Mon Feb 23 00:52:08 2015 KENTNL [...] cpan.org - Requestor KENTNL added

Mon Feb 23 00:52:34 2015 KENTNL [...] cpan.org - Broken in 1.101 added

Mon Feb 23 00:52:34 2015 KENTNL [...] cpan.org - Broken in 1.102 added

Sat Jun 09 12:32:43 2018 REHSACK [...] cpan.org - Ticket #40158: Merged into ticket #84914

Sat Jun 09 12:32:43 2018 REHSACK [...] cpan.org - Merged into ticket #84914

Wed Oct 21 02:19:43 2020 REHSACK [...] cpan.org - Correspondence added

Seems to be fixed in 1.110

Wed Oct 21 02:19:44 2020 The RT System itself - Status changed from 'new' to 'open'

Wed Oct 21 02:19:44 2020 REHSACK [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #84914 for File-ShareDir: _dist_file_new assumes _dist_dir_new returns a defined value