Bug #84876 for JSON: JSON::XS is being installed unconditionally in non-interactive mode

Fri Apr 26 13:19:29 2013 ether [...] cpan.org - Ticket created

Subject:

JSON::XS is being installed unconditionally in non-interactive mode

This is a problem on 5.17.*, where JSON::XS is broken (due to hash randomization changes). Makefile.PL should detect when a terminal is not present, and not prompt to install JSON::XS, because when there is no interactivity, this defaults to Y, and then installation fails when JSON::XS fails. I'm not sure if there's a way of detecting that JSON::XS fails to install -- if it can do this, then JSON's installation should still be able to proceed without it. I believe the Lancaster consensus had some things to say about how this should be done, too.

Fri Apr 26 13:36:18 2013 ether [...] cpan.org - Correspondence added

Show quoted text

> I believe the Lancaster consensus had some things to say about how > this should be done, too.

10:33 <@leont> It should recommend JSON::XS instead of require 10:33 <@leont> Though one could argue it could instead unrequire it given PUREPERL_ONLY=1 10:35 <@rjbs> It should either (a) add a "recommend" without asking or (b) change the default based on PUREPERL_ONLY. 10:35 <@rjbs> imho

Wed May 22 12:44:13 2013 ether [...] cpan.org - Correspondence added

On 2013-04-26 10:36:18, ETHER wrote: Show quoted text

>

> > I believe the Lancaster consensus had some things to say about how > > this should be done, too.

> > 10:33 <@leont> It should recommend JSON::XS instead of require > 10:33 <@leont> Though one could argue it could instead unrequire it given > PUREPERL_ONLY=1 > 10:35 <@rjbs> It should either (a) add a "recommend" without asking or (b) > change the default based on PUREPERL_ONLY. > 10:35 <@rjbs> imho >

This is important to fix, as it's currently impossible to install JSON (without --force) in non-interactive mode under 5.18.0, as JSON::XS will not install cleanly.

Wed May 22 12:44:20 2013 ether [...] cpan.org - Severity Important added

Wed May 22 20:28:32 2013 makamaka [...] cpan.org - Correspondence added

I released new version. You will get it from CPAN for a while. https://metacpan.org/release/MAKAMAKA/JSON-2.58 Thanks! On 2013-5月-22 水 12:44:13, ETHER wrote: Show quoted text

> On 2013-04-26 10:36:18, ETHER wrote:

> >

> > > I believe the Lancaster consensus had some things to say about how > > > this should be done, too.

> > > > 10:33 <@leont> It should recommend JSON::XS instead of require > > 10:33 <@leont> Though one could argue it could instead unrequire it

> given

> > PUREPERL_ONLY=1 > > 10:35 <@rjbs> It should either (a) add a "recommend" without asking

> or (b)

> > change the default based on PUREPERL_ONLY. > > 10:35 <@rjbs> imho > >

> > > This is important to fix, as it's currently impossible to install JSON > (without --force) in non-interactive mode under 5.18.0, as JSON::XS > will not install cleanly. >

Wed May 22 20:28:33 2013 The RT System itself - Status changed from 'new' to 'open'

Wed May 22 20:29:11 2013 makamaka [...] cpan.org - Correspondence added

closed.

Wed May 22 20:29:11 2013 makamaka [...] cpan.org - Status changed from 'open' to 'resolved'