Subject: | Add ability to re-open log_file error log |
Greetings,
We've been discussing reopening the error log on the github repository for Starman which subclasses Net::Server (https://github.com/miyagawa/Starman/issues/55).
I've found a couple of ways to do it from within Starman but it looks like the simplest way (i.e.: fiddling with the private(?) _SERVER_LOG file handle when a signal is sent) would break Net::Server's API.
Should this handle be considered private? If so I'm willing to do the work (and tests, docs) to replace the private _SERVER_LOG filehandle with a piece of public member data like $prop->{server_log_fh}.
This would make the handle part of the API and any subclass would have access to it.
Granted this could also be done through the pluggable logging but it seems like this might be a good feature for Net::Server itself.
Thanks,
--
Ben