Skip Menu |

This queue is for tickets about the Perl-Critic-Nits CPAN distribution.

Report information
The Basics
Id: 84820
Status: open
Priority: 0/
Queue: Perl-Critic-Nits
People
Owner: Nobody in particular
Requestors: miyagawa [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Apr 23 20:49:40 2013 miyagawa [...] gmail.com - Ticket created
Subject: Severity shouldn't be 5
Date: Wed, 24 Apr 2013 09:49:10 +0900
To: bug-Perl-Critic-Nits [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Similar to #35440, but merely installing this module makes all of perlcritic tests fail because its severity is high, and by default Perl::Critic loads all installed policies. Lower the severity or all I can ask for the users is to just uninstall this module. -- Tatsuhiko Miyagawa
  Fri May 10 17:05:38 2013 mschwern [...] cpan.org - Correspondence added
Seconded.  This got accidentally installed as part of Task::Perl::Critic (which I didn't realize installed every policy) and messed things up.  Every module's perlcritic test started failing.  The policy throws *a lot* of false positives.
  Fri May 10 17:05:38 2013 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 18 11:26:23 2013 ether [...] cpan.org - Correspondence added
On 2013-05-10 14:05:38, MSCHWERN wrote: Show quoted text
> Seconded. This got accidentally installed as part of > Task::Perl::Critic (which > I didn't realize installed every policy) and messed things up. Every > module's > perlcritic test started failing. The policy throws *a lot* of false > positives.
Every module's perlcritic test started failing?? Shouldn't this test be restricted to AUTHOR_TESTING or RELEASE_TESTING?
  Tue Jun 18 13:06:26 2013 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #84820] Severity shouldn't be 5
Date: Tue, 18 Jun 2013 10:05:51 -0700
To: bug-Perl-Critic-Nits [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
On Tue, Jun 18, 2013 at 8:26 AM, Karen Etheridge via RT <bug-Perl-Critic-Nits@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=84820 > > > On 2013-05-10 14:05:38, MSCHWERN wrote:
>> Seconded. This got accidentally installed as part of >> Task::Perl::Critic (which >> I didn't realize installed every policy) and messed things up. Every >> module's >> perlcritic test started failing. The policy throws *a lot* of false >> positives.
> > Every module's perlcritic test started failing?? Shouldn't this test be restricted to AUTHOR_TESTING or RELEASE_TESTING?
If "by test" you mean the entire Perl::Critic test, probably. But that's orthogonal to this module being overly critic and break tests that otherwise pass. It's also a design issue in Perl::Critic where it enables all installed policies by default, but let's discuss elsewhere about that. -- Tatsuhiko Miyagawa