| CC: | bug-Test-Kwalitee [...] rt.cpan.org |
| Subject: | Re: Test::Kwalitee |
| Date: | Sat, 20 Apr 2013 16:44:12 -0700 |
| To: | kevin dawson <kevin [...] dawson10.plus.com> |
| From: | Karen Etheridge <ether [...] cpan.org> |
You called ->import twice. Check RELEASE_TESTING first, then call
Test::Requires, which calls ->import for you.
PS. I'm cc'ing the bugtracker for visibility, as I'm not the only
maintainer of this distribution.
On Sat, Apr 20, 2013 at 07:07:05PM +0100, kevin dawson wrote:
Show quoted text
> hi ether,
>
> I am in process of updating my xt/
>
> use strict;
> use warnings FATAL => 'all';
>
> use English qw( -no_match_vars );
> local $OUTPUT_AUTOFLUSH = 1;
>
> use Test::More;
> use Test::Requires { 'Test::Kwalitee' => 1.02 };
>
> plan( skip_all => 'Author tests not required for installation' ) unless
> $ENV{RELEASE_TESTING};
>
> Test::Kwalitee->import();
>
> done_testing();
>
> __END__
>
> I get the following
>
> kevin@billy:~/GitHub/App-Midgen$ prove -lv xt/kwalitee.t
> xt/kwalitee.t ..
> 1..13
> ok 1 - extractable
> ok 2 - has_readme
> ok 3 - has_manifest
> ok 4 - has_meta_yml
> ok 5 - has_buildtool
> ok 6 - has_changelog
> ok 7 - no_symlinks
> ok 8 - has_tests
> ok 9 - proper_libs
> ok 10 - no_pod_errors
> not ok 11 - use_strict
>
> # Failed test 'use_strict'
> # at
> /home/kevin/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Kwalitee.pm
> line 103.
> # Add 'use strict' to all modules.This distribution does not 'use
> strict;' in all of its modules.
> ok 12 - has_test_pod
> ok 13 - has_test_pod_coverage
> You tried to plan twice at xt/kwalitee.t line 10.
> # Looks like you failed 1 test of 13.
> # Looks like your test exited with 255 just after 13.
> Dubious, test returned 255 (wstat 65280, 0xff00)
> Failed 1/13 subtests
>
> Test Summary Report
> -------------------
> xt/kwalitee.t (Wstat: 65280 Tests: 13 Failed: 1)
> Failed test: 11
> Non-zero exit status: 255
> Files=1, Tests=13, 10 wallclock secs ( 0.03 usr 0.01 sys + 1.74 cusr
> 0.22 csys = 2.00 CPU)
> Result: FAIL
>
>
> is this all my doing ? or is there an issue with using Test-Required
> with Test-Kwalitee.
>
> regards
> kevin
>
--
The only consistent feature of all of your dissatisfying relationships is you.
. . . . .
Karen Etheridge, karen@etheridge.ca GCS C+++$ USL+++$ P+++$ w--- M++