Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the devel-nytprof CPAN distribution.

Report information
The Basics
Id: 84738
Status: resolved
Priority: 0/
Queue: devel-nytprof
People
Owner: Nobody in particular
Requestors: MITHALDU [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Apr 19 08:51:42 2013 MITHALDU [...] cpan.org - Ticket created
Subject: 5.00 does not compile on windows
See: http://www.cpantesters.org/cpan/report/84745eec-6bf8-1014-984d-e8e44511453d I got exactly the same errors on ActivePerl 5.12.4
  Fri Apr 19 11:47:11 2013 TIMB [...] cpan.org - Correspondence added
Fixed. 5.01 uploaded to PAUSE. Thanks!
  Fri Apr 19 11:47:12 2013 The RT System itself - Status changed from 'new' to 'open'
  Fri Apr 19 11:47:12 2013 TIMB [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Apr 19 20:14:40 2013 JDB [...] cpan.org - Correspondence added
On Fri Apr 19 11:47:11 2013, TIMB wrote: Show quoted text
> Fixed. 5.01 uploaded to PAUSE. Thanks!
But not to Github...
  Fri Apr 19 20:24:58 2013 JDB [...] cpan.org - Correspondence added
On Fri Apr 19 11:47:11 2013, TIMB wrote: Show quoted text
> Fixed. 5.01 uploaded to PAUSE. Thanks!
Your fix is also not correct: you create a file_name_copy string, but you still output the original file_name. So at the end of the WIN32 block you should add an assignment: file_name = file_name_copy Cheers, -Jan
  Fri Apr 19 20:24:58 2013 JDB [...] cpan.org - Status changed from 'resolved' to 'open'
  Sun Apr 21 16:02:24 2013 TIMB [...] cpan.org - Correspondence added
Show quoted text
> Your fix is also not correct: you create a file_name_copy string, but > you still output the original file_name.
Oh, phooey! I've pushed the fix to github and uploaded a Devel-NYTProf-5.01_90.tar.gz to PAUSE. Could you check it, and nytprof on windows in general?
  Mon Apr 22 16:10:40 2013 JDB [...] cpan.org - Correspondence added
On Sun Apr 21 16:02:24 2013, TIMB wrote: Show quoted text
> > Your fix is also not correct: you create a file_name_copy string,
> but
> > you still output the original file_name.
> > Oh, phooey! I've pushed the fix to github and uploaded a Devel- > NYTProf-5.01_90.tar.gz to PAUSE. > > Could you check it, and nytprof on windows in general?
I tried the HEAD of master on Win2000 with VC and Perl 5.16.2, and everything builds and tests ok. Make a 5.0.2 release! :)
  Mon Apr 22 16:53:51 2013 Tim.Bunce [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #84738] 5.00 does not compile on windows
Date: Mon, 22 Apr 2013 21:53:32 +0100
To: Jan Dubois via RT <bug-devel-nytprof [...] rt.cpan.org>
From: Tim Bunce <Tim.Bunce [...] pobox.com>
On Mon, Apr 22, 2013 at 04:10:40PM -0400, Jan Dubois via RT wrote: Show quoted text
> > I tried the HEAD of master on Win2000 with VC and Perl 5.16.2, and everything builds and tests ok. Make a 5.0.2 release! :)
Done! Thanks. Tim.
  Tue Apr 23 12:40:03 2013 MITHALDU [...] cpan.org - Correspondence added
I can confirm that 5.02 works fine on my end, so thanks a lot for the quick fix to everyone involved! :D
  Tue Apr 23 12:40:03 2013 MITHALDU [...] cpan.org - Status changed from 'open' to 'resolved'