Bug #84643 for Probe-Perl: $^X should be quoted when used in qx()

Mon Apr 15 05:39:15 2013 https://www.google.com/accounts/o8/id?id=AItOawlVEP5IYeRHpH3ZT4ELVsJ3INWz0Lpegpo - Ticket created

Subject:

$^X should be quoted when used in qx()

Hi, Tests 13 (perl_is_same) and 17 (perl_inc) are failing because my Perl is installed under “c:\program files (x86)”. The two methods invoke qx($perl ...), resulting in the following error: 'C:\Program' is not recognized as an internal or external command, operable program or batch file. Please invoke as qx("$perl" ...) instead. Thanks, Sam

Wed Apr 17 22:52:59 2013 kwilliams [...] cpan.org - Correspondence added

Thanks for the report. Double-quotes would help, but there would still be problems with other shell metacharacters. I moved the repository to GitHub, and pushed out a fix that should take care of it properly. Could you try it out? https://github.com/kenahoo/Probe-Perl/commits/master If it looks fine to you, I can make a release.

Wed Apr 17 22:52:59 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Apr 18 01:27:32 2013 https://www.google.com/accounts/o8/id?id=AItOawlVEP5IYeRHpH3ZT4ELVsJ3INWz0Lpegpo - Correspondence added

From:

Sam Ferencik

Hi, Thanks, but I can't see the fix on github. There are three commits from yesterday, but none of them seem to touch the code in question. The two subroutines still call $perl (bare) on a command-line. Sam

Thu Apr 18 08:23:24 2013 kwilliams [...] cpan.org - Correspondence added

Oops, sorry, I forgot to push the last change. Should be there now.

Fri Apr 19 02:28:48 2013 https://www.google.com/accounts/o8/id?id=AItOawlVEP5IYeRHpH3ZT4ELVsJ3INWz0Lpegpo - Correspondence added

From:

Sam Ferencik

Thank you, that works fine. (Perhaps _backticks() deserves a comment about the motivation.)

Fri Apr 19 07:40:32 2013 kwilliams [...] cpan.org - Correspondence added

Okay, I pushed a release to CPAN. Thanks.

Fri Apr 19 07:40:32 2013 kwilliams [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Apr 19 11:21:01 2013 https://www.google.com/accounts/o8/id?id=AItOawlVEP5IYeRHpH3ZT4ELVsJ3INWz0Lpegpo - Correspondence added

From:

Sam Ferencik

Ken, I'm terribly sorry, but this isn't working. It crashes with List form of pipe open not implemented at Probe/Perl.pm line 52. after test 12, as soon as _backticks() is called. I see now that it crashed also when I "retested" it this morning, but I missed it - probably because it plain dies and there isn't the customary "not ok ... Failed test 13" output. It's a nice column of "ok X". Sorry for the oversight. http://www.perlmonks.org/?node_id=902197 seems to suggest that the error is a fact of life on Windows. Can you reopen the ticket, or should I enter a new one? Sam

Fri Apr 19 11:34:35 2013 kwilliams [...] cpan.org - Correspondence added

I'm seeing a successful test on Cygwin, but I don't have a pure Windows environment yet. I can try creating one to test it here too. I'll just re-open this ticket. Thanks for checking back.

Fri Apr 19 11:34:35 2013 kwilliams [...] cpan.org - Status changed from 'resolved' to 'open'

Sun Apr 21 22:58:12 2013 kwilliams [...] cpan.org - Correspondence added

Care to try the latest Git HEAD? Might be working now.

Mon Apr 22 02:44:16 2013 https://www.google.com/accounts/o8/id?id=AItOawlVEP5IYeRHpH3ZT4ELVsJ3INWz0Lpegpo - Correspondence added

From:

Sam Ferencik

No, it's not working yet. The tests are still failing. Two issues: 1) Perl.pm, line 55: the open() call *dies* (as opposed to just returning false) with the "List form ... not implemented" message. When you wrap the call in eval so you survive the call... 2) Perl.pm, line 63: the regexp seems wrong; my value of $perl doesn't get quoted. It should say if $perl =~ /\s/. For reference, my $perl is "C:\Program Files (x86)\Perl\bin\perl.exe". Thanks, Sam

Wed May 01 09:12:34 2013 b244145 [...] tyldd.com - Correspondence added

On Sun Apr 21 22:58:12 2013, KWILLIAMS wrote: Show quoted text

> Care to try the latest Git HEAD? Might be working now.

use one of the Win32::ShellQuote functions :)

Wed May 01 09:49:32 2013 https://www.google.com/accounts/o8/id?id=AItOawlVEP5IYeRHpH3ZT4ELVsJ3INWz0Lpegpo - Correspondence added

From:

Sam Ferencik

I can't see the change. Have you perhaps forgot to push it to github?