Skip Menu |

This queue is for tickets about the Apache-Test CPAN distribution.

Report information
The Basics
Id: 84625
Status: resolved
Priority: 0/
Queue: Apache-Test

People
Owner: Nobody in particular
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.38
Fixed in: (no value)



Subject: Patch to t/sok.t for Test::Builder 1.5.0

t/sok.t is testing the TAP output from Test::Builder.  A minor change to the format will be introduced in version 1.5.0, "# skip" will be normalized to "# SKIP".


Fortunately the fix is pretty simple, make the match case insensitive.  In general Test::Builder::Tester should be used.  This patch implements the simple fix.

Subject: 0001-Patch-t-sok.t-for-Test-Builder-1.5.0.patch
From 8637cfc7c936d7f89bff3790734834700c9713db Mon Sep 17 00:00:00 2001 From: "Michael G. Schwern" <schwern@pobox.com> Date: Sun, 14 Apr 2013 15:28:46 +0100 Subject: [PATCH] Patch t/sok.t for Test::Builder 1.5.0. The skip directive was normalized from "# skip" to "# SKIP". --- t/sok.t | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git t/sok.t t/sok.t index b59f31b..e319204 100644 --- t/sok.t +++ t/sok.t @@ -86,7 +86,7 @@ Test::ok $output=~/^ok 1$/m && sok {1}; } Test::ok $output=~/^ok 1$/m && - $output=~/^ok 2 # skip skipping this subtest$/m && + $output=~/^ok 2 # skip skipping this subtest$/mi && $output=~/^ok 3$/m; { @@ -144,8 +144,8 @@ Test::ok $output=~/^ok 1$/m && sok {1}; } Test::ok $output=~/^ok 1$/m && - $output=~/^ok 2 # skip skipping this subtest$/m && - $output=~/^ok 3 # skip skipping this subtest$/m && + $output=~/^ok 2 # skip skipping this subtest$/mi && + $output=~/^ok 3 # skip skipping this subtest$/mi && $output=~/^ok 4$/m; { @@ -163,6 +163,6 @@ Test::ok $output=~/^ok 1$/m && sok {1}; } Test::ok $output=~/^ok 1$/m && - $output=~/^ok 2 # skip skipping this subtest$/m && - $output=~/^ok 3 # skip skipping this subtest$/m && + $output=~/^ok 2 # skip skipping this subtest$/mi && + $output=~/^ok 3 # skip skipping this subtest$/mi && $output=~/^ok 4$/m; -- 1.8.0.3
Thanks for the patch. Now applied to Apache-Test trunk in r1605027 (with one extra /m -> /mi that was missed).