Bug #84577 for Astro-ADS: Bug in a test in Astro::ADS::Query

Thu Apr 11 14:39:55 2013 skutch [...] head.cfa.harvard.edu - Ticket created

Subject:	Bug in a test in Astro::ADS::Query
Date:	Thu, 11 Apr 2013 14:39:36 -0400
To:	bug-Astro-ADS [...] rt.cpan.org
From:	Glenn Becker <skutch [...] head.cfa.harvard.edu>

Hi, On trying to install Astro::ADS, I discovered a bug in one of the tests for Astro::ADS::Query. Line 146 in the file paper.t has a test that expects the number of references in the paper used as an example (1998MNRAS.295..167A) to be 27. Unfortunately, ADS has 30 references for this paper: http://adsabs.harvard.edu.ezp-prod1.hul.harvard.edu/cgi-bin/nph-ref_query?bibcode=1998MNRAS.295..167A&refs=REFERENCES&db_key=AST ... so the test, and the install, fails. Please let me know if you need any more information. Thx, Glenn Becker -- +------------------------------------------------------------+ Glenn Becker Chandra Data Archive Office: B-241 60 Garden St. MS 67 Phone: 617-496-2591 Cambridge, MA 02138 skutch@head.cfa.harvard.edu +------------------------------------------------------------+

Fri Apr 12 04:54:08 2013 DUFFEE [...] cpan.org - Correspondence added

On Thu Apr 11 14:39:55 2013, skutch@head.cfa.harvard.edu wrote: Show quoted text

> On trying to install Astro::ADS, I discovered a bug in one of the > tests for Astro::ADS::Query. > > Line 146 in the file paper.t has a test that expects the number of > references in the paper used as an example (1998MNRAS.295..167A) to be > 27. Unfortunately, ADS has 30 references for this paper:

Hi Glenn, It's a known issue with a fix (a tricky test to write since the value can always change). Since I've got co-maint status, I've been busy with other things, but it's on my todo list. The version on CPAN is also susceptible to the ampersand bug. A better version is on github at https://github.com/duffee/perl-modules-for-astronomy Are you using Astro::ADS (in which case I'll unshift it on the queue) or are you just running QA checks? best, Boyd

Fri Apr 12 04:54:08 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Apr 12 09:41:44 2013 skutch [...] head.cfa.harvard.edu - Correspondence added

Subject:	Re: [rt.cpan.org #84577] Bug in a test in Astro::ADS::Query
Date:	Fri, 12 Apr 2013 09:41:21 -0400
To:	bug-Astro-ADS [...] rt.cpan.org
From:	Glenn Becker <skutch [...] head.cfa.harvard.edu>

Hi Boyd, Show quoted text

> Hi Glenn, > > It's a known issue with a fix (a tricky test to write since the value can always change). Since I've got co-maint status, I've been busy with other things, but it's on my todo list. The version on CPAN is also susceptible to the ampersand bug. A better version is on github at > > https://github.com/duffee/perl-modules-for-astronomy > > Are you using Astro::ADS (in which case I'll unshift it on the queue) or are you just running QA checks? > > best, > Boyd

Thanks for the quick reply. FWIW I am migrating our Perl codebase to live in a perlbrew environment, so am doing a _lot_ of module reinstalls/builds. At least one of our scripts calls Astro::ADS::Query ... and since I'm proceeding alphabetically, it came up quickly ;). A coworker -- who is much more experienced with this stuff than me -- told me CPAN had a mechanism for patching before building, which I may try. I didn't know about it. Or I'll install the github version you point out. Thanks! /Glenn -- +------------------------------------------------------------+ Glenn Becker Chandra Data Archive Office: B-241 60 Garden St. MS 67 Phone: 617-496-2591 Cambridge, MA 02138 skutch@head.cfa.harvard.edu +------------------------------------------------------------+

Wed Aug 07 04:48:42 2013 DUFFEE [...] cpan.org - Correspondence added

Sorry for the delay in getting the bug fix on CPAN. Although a patched version was available on github, I had to negotiate co-maintenance on the module with the author who's doing other things and then find the time to tidy up all the tests in between my real job. Thank you for your interest and please let me know if you find more bugs. They will be address much more promptly in future.

Wed Aug 07 04:48:43 2013 DUFFEE [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Aug 07 04:48:43 2013 DUFFEE [...] cpan.org - Taken

Wed Aug 07 04:48:43 2013 DUFFEE [...] cpan.org - Fixed in 1.25 added

Wed Aug 07 04:48:43 2013 DUFFEE [...] cpan.org - Fixed in 1.25.1 added