Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Git CPAN distribution.

Report information
The Basics
Id: 84560
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-Git

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.012
Fixed in: (no value)



Subject: [Git::Check] should probably auto-ignore a few standard things

There's 3 things that should probably be ignored by default:

.build
{{ $zilla->dist_basename }}
{{ $zilla->archive_filename }}

Considering that:

  • Those paths are practically guaranteed to exist for everyone using dist::zilla
  • everyone will want those paths ignored by default
  • people who are new to dist::zilla make that one of their first mistakes/changes to their build system
It just seems sane to automatically ignore them all, and have a way to turn that behaviour off if somebody is *really* picky about them.

On 2013-04-10 14:05:41, KENTNL wrote: Show quoted text
> There's 3 things that should probably be ignored by default: > > .build > {{ $zilla->dist_basename }} > {{ $zilla->archive_filename }} > > Considering that: > > * Those paths are practically guaranteed to exist for everyone using > dist::zilla > > * everyone will want those paths ignored by default > > * people who are new to dist::zilla make that one of their first > mistakes/changes to their build system > > It just seems sane to automatically ignore them all, and have a way to turn > that behaviour off if somebody is *really* picky about them.
I see where you're coming from here, but beginners are also likely to be using [GatherDir] (via @Basic) rather than [Git::GatherDir], and if [Git::Check] ignored these things by default, they can easily end up being bundled up in the dist tarball by accident. (This can still happen if one adds these patterns to a .gitignore but still uses [GatherDir], but at least they had to manually create a .gitignore, meaning they are aware these files might exist. Now, if PruneCruft automatically pruned them.... that might be more useful! And probably [Git::Check] should ignore the same things that [PruneCruft] does.)