Bug #84546 for XML-SemanticDiff: Zero node value treated as undefined or missing

> I'm not sure if this module is still active, but I found a minor bug. > > If a node's text is the value zero, e.g. <weight>0</weight>, it is > treated as empty/undefined. > > I made a quick fix to my copy as shown below. > > In sub Text: > > Before: $self->char_accumulator()->{$element} .= $char if $char; > After: $self->char_accumulator()->{$element} .= $char if > defined($char); > > In sub EndTag: > > Before: $text ||= 'o'; > After: Removed - the MD5 encode function will treat the undefined > string the same as an empty string which is fine for my purposes. > > Thanks, > Nick > > --- > This email may contain confidential information and is for the sole > use of the intended recipient(s).  Any unauthorized use or > disclosure of this communication is prohibited.  If you have > received this email in error please delete it and notify sender.

-----Original Message----- From: Shlomi Fish via RT [mailto:bug-XML-SemanticDiff@rt.cpan.org] Sent: Friday, 12 April 2013 4:45 AM To: Nicholas Phillips Subject: [rt.cpan.org #84546] Zero node value treated as undefined or missing <URL: https://rt.cpan.org/Ticket/Display.html?id=84546 > Hi Nicholas, please submit a pull request to: https://bitbucket.org/shlomif/perl-xml-semanticdiff See: http://www.shlomifish.org/open-source/resources/how-to-contribute-to-my-projects/ for the guidelines. Regards, — Shlomi Fish On Wed Apr 10 02:12:24 2013, Nicholas.Phillips@computershare.com.au wrote: --- This email may contain confidential information and is for the sole use of the intended recipient(s).  Any unauthorized use or disclosure of this communication is prohibited.  If you have received this email in error please delete it and notify sender.