| Subject: | [PATCH] Redundant use of done_testing in POD coverage test |
The use of done_testing() in the newly-added POD coverage test is redundant because all_pod_coverage_ok() define its own plan.
If you really need to use it, a better test for its availability is to check for Test::More version 0.88 or later rather than checking for perl 5.8.6 or later.
In case you're wondering, I (as a downstream packager) habitually run maintainer tests, not because they add value for the module I'm packaging at the time but to give wider testing for the maintainer test modules themselves.
| Subject: | Filter-1.49-done-testing.patch |
--- t/z_pod-coverage.t
+++ t/z_pod-coverage.t
@@ -3,7 +3,6 @@
use warnings;
use Test::More;
-plan skip_all => 'done_testing requires 5.8.6' if $] <= 5.008005;
plan skip_all => 'This test is only run for the module author'
unless -d '.git' || $ENV{IS_MAINTAINER};
@@ -12,5 +11,3 @@
if $@;
all_pod_coverage_ok();
-
-done_testing();