Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the boolean CPAN distribution.

Report information
The Basics
Id: 84398
Status: open
Priority: 0/
Queue: boolean
People
Owner: Nobody in particular
Requestors: chip [...] pobox.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.29
Fixed in: (no value)

History Show all quoted text
  Wed Apr 03 00:35:09 2013 chip [...] pobox.com - Ticket created
Subject: TO_JSON has wrong prototype
as an object method w/o parameters, TO_JSON should either have no prototype or at most ($). PS: Hi, Ingy
  Thu Apr 04 13:59:38 2013 ingy [...] cpan.org - Correspondence added
Fixed in 0.30 I don't really understand how to make it fail with the empty prototype, so I just trusted chip and removed the prototype. Feel free to enlighten me. Also added a little doc about the JSON support. Chip I msg'd you on irc. Oh and, Hi.
  Thu Apr 04 13:59:38 2013 The RT System itself - Status changed from 'new' to 'open'
  Thu Apr 04 13:59:39 2013 ingy [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Apr 04 15:59:10 2013 chip [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #84398] TO_JSON has wrong prototype
Date: Thu, 04 Apr 2013 12:58:55 -0700
To: bug-boolean [...] rt.cpan.org
From: Chip Salzenberg <chip [...] pobox.com>
Thanks, Ingy. You can make the old one fail for a test by trying to call it as a function. $bool->TO_JSON # always did work boolean::TO_JSON($bool); # will fail with old prototype
  Thu Apr 04 15:59:11 2013 The RT System itself - Status changed from 'resolved' to 'open'
  Sat Apr 13 22:47:39 2013 ingy [...] cpan.org - Correspondence added
On Thu Apr 04 15:59:10 2013, CHIPS wrote: Show quoted text
> Thanks, Ingy. You can make the old one fail for a test by trying to > call it as a function. > > $bool->TO_JSON # always did work > boolean::TO_JSON($bool); # will fail with old prototype >
Thanks Chip. I've added a test to assert/guard that behavior. https://github.com/ingydotnet/boolean-pm/commit/b4f6934ab0d11e5e2e71d5668557d09304d2c6d8 I was wondering how much you've used boolean.pm and whether you consider it well behaved enough to be added to core modules.
  Sat Apr 13 23:21:05 2013 chip [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #84398] TO_JSON has wrong prototype
Date: Sat, 13 Apr 2013 20:20:41 -0700
To: bug-boolean [...] rt.cpan.org
From: Chip Salzenberg <chip [...] pobox.com>
On 4/13/2013 7:47 PM, Ingy dot Net via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=84398 > > > On Thu Apr 04 15:59:10 2013, CHIPS wrote:
>> Thanks, Ingy. You can make the old one fail for a test by trying to >> call it as a function. >> >> $bool->TO_JSON # always did work >> boolean::TO_JSON($bool); # will fail with old prototype >>
> > Thanks Chip. I've added a test to assert/guard that behavior. https://github.com/ingydotnet/boolean-pm/commit/b4f6934ab0d11e5e2e71d5668557d09304d2c6d8
Rock. Show quoted text
> I was wondering how much you've used boolean.pm and whether you consider it well behaved enough to be added to core modules. >
I use it in production. I like it. I haven't gone so far as to politick for it, but I'd happily accept it if it were ... er, accepted. :)