Bug #84256 for Data-Schema: Bleadperl v5.17.9-201-g3078e10 breaks SHARYANTO/Data-Schema-0.135.tar.gz

Thu Mar 28 08:33:06 2013 ANDK [...] cpan.org - Ticket created

CC:	demerphq [...] gmail.com
Subject:	Bleadperl v5.17.9-201-g3078e10 breaks SHARYANTO/Data-Schema-0.135.tar.gz

As per subject. Canonical ticket for the issue is https://rt.perl.org/rt3//Public/Bug/Display.html?id=117313 Hash randomization is involved. Since the cited commit we seem to have *only* fails on Data-Schema-0.135, not just random ones. Sample fail report: http://www.cpantesters.org/cpan/report/a533357e-90f4-11e2-aa31-fa243b384401 HTH,

Thu Mar 28 09:04:03 2013 demerphq [...] gmail.com - Correspondence added

CC:	Perl5 Porteros <perl5-porters [...] perl.org>
Subject:	Re: [rt.cpan.org #84256] Bleadperl v5.17.9-201-g3078e10 breaks SHARYANTO/Data-Schema-0.135.tar.gz
Date:	Thu, 28 Mar 2013 14:03:53 +0100
To:	bug-Data-Schema [...] rt.cpan.org
From:	demerphq <demerphq [...] gmail.com>

On 28 March 2013 13:33, Andreas Koenig via RT <bug-Data-Schema@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=84256 > > > As per subject. Canonical ticket for the issue is https://rt.perl.org/rt3//Public/Bug/Display.html?id=117313 > > Hash randomization is involved. > > Since the cited commit we seem to have *only* fails on Data-Schema-0.135, not just random ones. > > Sample fail report: > > http://www.cpantesters.org/cpan/report/a533357e-90f4-11e2-aa31-fa243b384401 > > HTH,

The module says: NOTE: THIS MODULE IS DEPRECATED AND WILL NOT BE DEVELOPED FURTHER. PLEASE SEE Data::Sah INSTEAD. And the code failing is this: sub _schema2csubname { my ($self, $schema) = @_; # avoid warning from Storable when trying to freeze coderef local $self->config->{gettext_function} = ($self->config->{gettext_function} // "").""; my $n1 = defined($schema) ? (ref($schema) ? md5_hex(freeze($schema)) : $schema) : ""; my $n2 = md5_hex(freeze($self->config)); "__cs_${n1}_$n2"; } I'd say this code only worked by chance anyway. The whole idea of using Storable::freeze() as the basis of deduping things seems to me to be fraught with error. The solution would be to use something like Data::Dumper instead, with Sortkeys enabled. Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"

Thu Mar 28 09:04:04 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 29 12:53:36 2013 sharyanto [...] cpan.org - Correspondence added

Author here. On Thu Mar 28 09:04:03 2013, demerphq@gmail.com wrote: Show quoted text

> I'd say this code only worked by chance anyway. The whole idea of > using Storable::freeze() as the basis of deduping things seems to me > to be fraught with error.

Not really. Storable is just Yet Another serialization. It seems that all I have to do is set $Storable::canonical to 1 to let Storable sort hash keys. Show quoted text

> The solution would be to use something like > Data::Dumper instead, with Sortkeys enabled.

Regards, Steven

Fri Mar 29 12:56:57 2013 demerphq [...] gmail.com - Correspondence added

CC:	ANDK [...] cpan.org
Subject:	Re: [rt.cpan.org #84256] Bleadperl v5.17.9-201-g3078e10 breaks SHARYANTO/Data-Schema-0.135.tar.gz
Date:	Fri, 29 Mar 2013 17:56:45 +0100
To:	bug-Data-Schema [...] rt.cpan.org
From:	demerphq <demerphq [...] gmail.com>

On 29 March 2013 17:53, steven haryanto via RT <bug-Data-Schema@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=84256 > > > Author here. > > On Thu Mar 28 09:04:03 2013, demerphq@gmail.com wrote:

>> I'd say this code only worked by chance anyway. The whole idea of >> using Storable::freeze() as the basis of deduping things seems to me >> to be fraught with error.

> > Not really. Storable is just Yet Another serialization. It seems that all I have to do is set $Storable::canonical to 1 to let Storable sort hash keys.

I had forgotten that Storable offered that feature, sorry. Be aware however it modifies the data structure it is serializing (it stringifies all SV's in the structure). Anyway, afaik, if you turn that on Data::Schema should pass. Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"

Fri Mar 29 13:01:19 2013 sharyanto [...] cpan.org - Correspondence added 4 min

OK, I'm releasing 0.136 to CPAN now with $Storable::canonical=1. Thanks, Steven

Fri Mar 29 13:01:20 2013 sharyanto [...] cpan.org - Status changed from 'open' to 'resolved'