Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the ZMQ-LibZMQ3 CPAN distribution.

Report information
The Basics
Id: 84124
Status: open
Priority: 0/
Queue: ZMQ-LibZMQ3
People
Owner: Nobody in particular
Requestors: Mark.Martinec [...] ijs.si
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.10
Fixed in: (no value)

History Show all quoted text
  Thu Mar 21 13:48:35 2013 Mark.Martinec [...] ijs.si - Ticket created
Subject: cc -pedantic-errors incompatible witrh perl 5.17.9 (when compiling zmqcheck)

Message body is not shown because it is too large.

  Thu Mar 21 19:33:47 2013 dmaki [...] cpan.org - Correspondence added
Given some discussion on #p5p, I suspect that there is something wrong in the bleadperl isn't setting PERL_GCC_PEDANTIC. You might want to file this bug via perlbug. If they decide to release perl-5.18 without fixing this, I'll release a new version with manual PERL_GCC_PEDANTIC define.
  Thu Mar 21 19:33:47 2013 The RT System itself - Status changed from 'new' to 'open'
  Fri Mar 22 15:33:57 2013 Mark.Martinec [...] ijs.si - Correspondence added
From: Mark.Martinec [...] ijs.si
Show quoted text
> Given some discussion on #p5p, I suspect that there is something wrong > in the bleadperl isn't setting PERL_GCC_PEDANTIC. You might want to > file this bug via perlbug.
Done: [perl #117305] ISO C forbids braced-groups within expressions (cv.h, inline.h in 5.17.9) https://rt.perl.org:443/rt3/Ticket/Display.html?id=117305 Mark
  Mon Mar 25 07:04:53 2013 Mark.Martinec [...] ijs.si - Correspondence added
Subject: Re: [rt.cpan.org #84124] cc -pedantic-errors incompatible witrh perl 5.17.9 (when compiling zmqcheck)
Date: Mon, 25 Mar 2013 12:04:32 +0100
To: bug-ZMQ-LibZMQ3 [...] rt.cpan.org
From: Mark Martinec <Mark.Martinec [...] ijs.si>
We have a reply from Dave Mitchell on the related [perl #117305]. The summary there is essentially: Show quoted text
> I think (but I'm willing to be convinced otherwise), based on the above > (fairly innocuous) commit, that the situation is that if a module wants to > build itself with -pendantic, then it needs to set PERL_GCC_PEDANTIC too; > the fact that it wasn't needed in the past was just luck; the commit above > introduced some inline function definitions that made the use of > brace-groups "active" even for code that didn't directly or indirectly use > macros such as CvGV.
Mark
  Mon Mar 25 07:21:25 2013 dmaki [...] cpan.org - Correspondence added
Thanks, I'll whip out something in a few days.
  Mon Mar 25 08:20:32 2013 dmaki [...] cpan.org - Correspondence added
Mark, does the current master work for you? (https://github.com/lestrrat/p5-ZMQ)
  Mon Mar 25 11:03:05 2013 Mark.Martinec [...] ijs.si - Correspondence added
Subject: Re: [rt.cpan.org #84124] cc -pedantic-errors incompatible witrh perl 5.17.9 (when compiling zmqcheck)
Date: Mon, 25 Mar 2013 16:02:35 +0100
To: bug-ZMQ-LibZMQ3 [...] rt.cpan.org
From: Mark Martinec <Mark.Martinec [...] ijs.si>
Show quoted text
> Mark, does the current master work for you? > (https://github.com/lestrrat/p5-ZMQ)
Thanks for a prompt response. Show quoted text
> --- tools/zmqcheck/Makefile.PL 2013-01-09 09:46:28.000000000 +0100 > +++ tools/zmqcheck/Makefile.PL 2013-03-25 15:44:20.740478869 +0100 > @@ -28,4 +28,7 @@ > #include "perl.h" > #include <zmq.h> > +#ifndef PERL_GCC_PEDANTIC > +#define PERL_GCC_PEDANTIC > +#endif
No, it is the #include "perl.h" which chokes on -pedantic, so the '#define PERL_GCC_PEDANTIC' must come before the #include "perl.h". (the #include "EXTERN.h" is currently not problematic, so the '#define PERL_GCC_PEDANTIC' may be before or after it) Mark
  Tue May 21 13:41:40 2013 Mark.Martinec [...] ijs.si - Correspondence added
From: Mark.Martinec [...] ijs.si
Show quoted text
> No, it is the #include "perl.h" which chokes on -pedantic, so > the '#define PERL_GCC_PEDANTIC' must come before the #include "perl.h".
As of ZMQ-LibZMQ3 version 1.11 this is still broken (tested with perl 5.18.0). The correct order in tools/zmqcheck/Makefile.PL is: #ifndef PERL_GCC_PEDANTIC #define PERL_GCC_PEDANTIC #endif #include "EXTERN.h" #include "perl.h" #include <zmq.h> i.e. the #define PERL_GCC_PEDANTIC must come *before* the #include "perl.h" .
  Fri May 24 00:33:34 2013 dmaki [...] cpan.org - Correspondence added
Hi, sorry my mail server broke (*1), so I didn't receive your replies Just pushed a commit with PERL_GCC_PEDANTIC declared before perl.h hope that works for you?
  Wed May 29 18:41:57 2013 Mark.Martinec [...] ijs.si - Correspondence added
Subject: Re: [rt.cpan.org #84124] cc -pedantic-errors incompatible witrh perl 5.17.9 (when compiling zmqcheck)
Date: Thu, 30 May 2013 00:41:27 +0200
To: bug-ZMQ-LibZMQ3 [...] rt.cpan.org
From: Mark Martinec <Mark.Martinec [...] ijs.si>
Show quoted text
> Just pushed a commit with PERL_GCC_PEDANTIC declared before perl.h hope > that works for you?
Yes, that looks fine (in git), thank you! Mark