| Subject: | HTTP::Body::MultiPart still leaves temp files around. |
The attempted fix to use cleanup(1) and DESTROY is flawed in that it looks for $self->{upload}
items.
But, those are not created until the full part has been read. So, if the connection is aborted
(which is a common situation for uploads taking too long, for example) the temp file is never
cleaned up.
This could have significant impact over time for a production use.
The solution is to let File::Temp do its job and let File::Temp unlink when the object goes out of
scope. Then don't delete "fh" from the body part so it stays around until the upload object goes
out of scope.
This could break someone that is copying the filenname then then letting the upload go out of
scope, but it's a temp file after all and it should not live long. And it's much better than risking
filling up someone's /tmp.
Misusing HTTP::Body and having a file vanish should show up with minimal testing. Running out
of disk space is more likely to happen once in production.