Skip Menu |

This queue is for tickets about the Monitoring-Plugin CPAN distribution.

Report information
The Basics
Id: 83931
Status: resolved
Priority: 0/
Queue: Monitoring-Plugin

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: get_shortname() is not called with arguments
At https://metacpan.org/source/TONVOON/Nagios-Plugin-0.36/lib/Nagios/Plugin/Functions.pm#L123, get_shortname() is not called with any arguments. It should be called as get_shortname($arg), and the line above it (getting the shortname from the plugin) should be removed, as this is already done by get_shortname(). In the current code, there is no way to override the shortname if Nagios::Plugin::Functions is used directly. PS. If this code is hosted somewhere public like github, and you add the repository information to the distribution's metadata, I can provide a pull request. see http://perl5maven.com/how-to-add-link-to-version-control-system-of-a-cpan-distributions for more information.
This module will be renamed and deprecated due to trademark issues, feel free to open pull requests over here: https://github.com/monitoring-plugins/monitoring-plugin-perl thanks
Could you possibly move this ticket to over there? (You can move a ticket between any queues you control by editing the "Queue" field.)
sorry that this took so long. I finally moved this ticket to the new queue and the new module includes information about the github repository. So please feel free to submit a pull request over there: https://github.com/monitoring-plugins/monitoring-plugin-perl thanks
I will close this issue for now, please open a pull request on github if you have a patch suggestion.