Bug #83924 for Crypt-Blowfish: SvUPGRADE usage change

Wed Mar 13 10:57:29 2013 zefram [...] fysh.org - Ticket created

Subject:	SvUPGRADE usage change
Date:	Wed, 13 Mar 2013 14:57:11 +0000
To:	bug-Crypt-Blowfish [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

SvUPGRADE() can't be used as a truth-value expression in current perl. It never actually returned false, so there's no need for the conditional. Attached patch fixes. -zefram

Message body is not shown because sender requested not to inline it.

Mon May 20 17:42:20 2013 davido [...] cpan.org - Correspondence added

On Wed Mar 13 07:57:29 2013, zefram@fysh.org wrote: Show quoted text

> SvUPGRADE() can't be used as a truth-value expression in current perl. > It never actually returned false, so there's no need for the conditional. > Attached patch fixes.

I've applied your patch and uploaded it as an unauthorized release, version number 2.12_001. I also emailed the author to let him know. Since it's been a couple months since this bug was reported, and since Perl 5.18 is now out (which is incompatible with the non-patched versions), it became more critical.

Mon May 20 17:42:20 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 23 11:46:43 2013 DPARIS [...] cpan.org - Correspondence added

This ticket has been resolved in release 2.13 which has been uploaded to PAUSE. -dsp

Tue Jul 23 11:46:43 2013 DPARIS [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jul 23 11:46:44 2013 DPARIS [...] cpan.org - Taken