Skip Menu |

This queue is for tickets about the indirect CPAN distribution.

Report information
The Basics
Id: 83806
Status: resolved
Priority: 0/
Queue: indirect

People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.30



Subject: false positives with Devel::Declare
Date: Thu, 7 Mar 2013 12:23:52 +0000
To: bug-indirect [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
indirect-0.29 still generates some of the false positives that were behind the bug report for 0.28 [rt.cpan.org #83659], specifically the ones involving Devel::Declare. Test case: $ perl -v | grep This This is perl 5, version 16, subversion 1 (v5.16.1) built for x86_64-linux-ld $ cat t0 use Devel::Declare 0.006007 (); sub foo { } sub foo_magic { my($declarator, $offset) = @_; $offset += Devel::Declare::toke_move_past_token($offset); my $linestr = Devel::Declare::get_linestr(); substr $linestr, $offset, 0, "\n\n"; Devel::Declare::set_linestr($linestr); } BEGIN { Devel::Declare->setup_for("main", { foo => { const => \&foo_magic } }); } no indirect ":fatal"; my $x; foo; $x->m; 1; $ perl -c t0 Indirect call of method "m" on object "$x" at t0 line 15. -zefram
Subject: Re: [rt.cpan.org #83806] AutoReply: false positives with Devel::Declare
Date: Tue, 12 Mar 2013 14:12:28 +0000
To: Bugs in indirect via RT <bug-indirect [...] rt.cpan.org>
From: Zefram <zefram [...] fysh.org>
After fiddling a bit, I think that the logic you have for adjusting the offset when a newline is seen in the buffer, which you recently determined is not correct when PL_lex_inwhat is non-zero, is actually not correct in any case. Patch attached. -zefram

Message body is not shown because sender requested not to inline it.

Le Mar 12 Mar 2013 10:12:51, zefram@fysh.org a écrit : Show quoted text
> After fiddling a bit, I think that the logic you have for adjusting > the offset when a newline is seen in the buffer, which you recently > determined is not correct when PL_lex_inwhat is non-zero, is actually > not correct in any case. Patch attached. > > -zefram
Thanks for the patch. I'm pretty sure I tested this configuration when I was trying to fix the original issue, but for some reason it appeared like it did not work at that time. So I don't really understand why your patch works, but since I've been asked several times to apply it, it is now available in version 0.30. Vincent.