Bug #83785 for RADIUS_XMLParser: useless file

Hello Alexandr, I'm sorry to hear my distrib is causing some issues. I confirm radius.log can be removed from XMLParser distribution. This is used (mainly by myself, and always manually using example.pl) to avoid regression after each release. The new distrib. manifest will look like: Changes Makefile.PL MANIFEST README RADIUS/XMLParser.pm version.pl I can upload a 1.2.1 version without radius.log whenever you want. Honestly I did not work on portability on windows env. Sorry for that Please let me know what other issues you were talking about. I'll be glad to 1- submit a much cleaner version, and 2- learn from you how to improve my perl skills ! Looking forward to hearing from you Best regards, Antoine 2013/3/6 Alexandr Ciornii via RT <bug-RADIUS_XMLParser@rt.cpan.org> Show quoted text

On Sun Mar 10 17:59:31 2013, amend.antoine@gmail.com wrote: Show quoted text
Is it possible to easily reduce size of this file to use in a test? Show quoted text
END block of RADIUS::XMLParser should check if corresponding file names were set, so it would be possible to do "use RADIUS::XMLParser" from some program without really using it (like use only in some condition or in a test). I'm also attaching new Makefile.PL and a simple test (which should be put into 't' directory). All dependencies which are not included in core perl should be specified in Makefile.PL in section PREREQ_PM or TEST_REQUIRES. You should not just archive directory with distribution - use `make dist` to create archive. It will generate more standard name for distribution and a couple of metadata files. P.S. Please remove old versions after uploading a new one - it will save space on CPAN mirrors. -- Alexandr Ciornii, http://chorny.net

use Test::More tests => 1; use RADIUS::XMLParser; ok(1);

use ExtUtils::MakeMaker; # See lib/ExtUtils/MakeMaker.pm for details of how to influence # the contents of the Makefile that is written. WriteMakefile1( 'NAME' => 'RADIUS::XMLParser', 'VERSION_FROM' => 'version.pl', # finds $VERSION 'ABSTRACT_FROM' => 'RADIUS/XMLParser.pm', 'LICENSE' => 'perl', 'PREREQ_PM' => { 'XML::Writer' => 0, 'Storable' => 0, }, 'TEST_REQUIRES' => { 'Test::More' => 0, }, 'PM' => { map { ("$_.pm" => "\$(INST_LIBDIR)/$_.pm") } qw(RADIUS/XMLParser) }, 'dist' => {COMPRESS => 'gzip -9f', SUFFIX => 'gz'} ); sub WriteMakefile1 { #Compatibility code for old versions of EU::MM. Written by Alexandr Ciornii, version 0.23. Added by eumm-upgrade. my %params=@_; my $eumm_version=$ExtUtils::MakeMaker::VERSION; $eumm_version=eval $eumm_version; die "EXTRA_META is deprecated" if exists $params{EXTRA_META}; die "License not specified" if not exists $params{LICENSE}; if ($params{AUTHOR} and ref($params{AUTHOR}) eq 'ARRAY' and $eumm_version < 6.5705) { $params{META_ADD}->{author}=$params{AUTHOR}; $params{AUTHOR}=join(', ',@{$params{AUTHOR}}); } if ($params{TEST_REQUIRES} and $eumm_version < 6.64) { $params{BUILD_REQUIRES}={ %{$params{BUILD_REQUIRES} || {}} , %{$params{TEST_REQUIRES}} }; delete $params{TEST_REQUIRES}; } if ($params{BUILD_REQUIRES} and $eumm_version < 6.5503) { #EUMM 6.5502 has problems with BUILD_REQUIRES $params{PREREQ_PM}={ %{$params{PREREQ_PM} || {}} , %{$params{BUILD_REQUIRES}} }; delete $params{BUILD_REQUIRES}; } delete $params{CONFIGURE_REQUIRES} if $eumm_version < 6.52; delete $params{MIN_PERL_VERSION} if $eumm_version < 6.48; delete $params{META_MERGE} if $eumm_version < 6.46; delete $params{META_ADD} if $eumm_version < 6.46; delete $params{LICENSE} if $eumm_version < 6.31; WriteMakefile(%params); }