Skip Menu |

This queue is for tickets about the Compress-Snappy CPAN distribution.

Report information
The Basics
Id: 83778
Status: resolved
Priority: 0/
Queue: Compress-Snappy

People
Owner: Nobody in particular
Requestors: BULKDD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.19
Fixed in: 0.20



Subject: wont compile on Visual C Win32
This a notice to let you know some fixes were submitted to the upstream code source for your module. csnappy ( https://github.com/zeevt/csnappy ) doesn't compile with Visual C for Win32. Compress-Snappy also doesn't compile on Visual C ( http://code.activestate.com/ppm/Compress-Snappy/ ). Some fixes ( https://github.com/Sereal/Sereal/commits/master?page=2 starting at commit "Attempt to work around *some* MSVC compiler issues in Snappy" ) for Sereal ( http://search.cpan.org/~yves/Sereal-0.310/ ) were done recently. This made Sereal work ( http://code.activestate.com/ppm/Sereal/ ) on Win32. These changes were submitted to csnappy's github at https://github.com/zeevt/csnappy/pull/14 . If zeevt never responds, you should think about patching Compress-Snappy's copy of csnappy independently of its origin.
On Tue Mar 05 21:22:57 2013, BULKDD wrote: Show quoted text
> This a notice to let you know some fixes were submitted to the upstream > code source for your module. > > csnappy ( https://github.com/zeevt/csnappy ) doesn't compile with Visual > C for Win32. Compress-Snappy also doesn't compile on Visual C ( > http://code.activestate.com/ppm/Compress-Snappy/ ). Some fixes ( > https://github.com/Sereal/Sereal/commits/master?page=2 starting at > commit "Attempt to work around *some* MSVC compiler issues in Snappy" ) > for Sereal ( http://search.cpan.org/~yves/Sereal-0.310/ ) were done > recently. This made Sereal work ( > http://code.activestate.com/ppm/Sereal/ ) on Win32. These changes were > submitted to csnappy's github at > https://github.com/zeevt/csnappy/pull/14 . If zeevt never responds, you > should think about patching Compress-Snappy's copy of csnappy > independently of its origin.
Thanks for the heads up
pushed 0.20 with the latest csnappy source.
Test passes uneventfully on VC 2003 32 bits. Show quoted text
_____________________________________________________________________ C:\Documents and Settings\Owner\Desktop\cpan libs\Compress-Snappy-0.20>nmake tes t Microsoft (R) Program Maintenance Utility Version 7.10.3077 Copyright (C) Microsoft Corporation. All rights reserved. cp lib/Compress/Snappy.pm blib\lib\Compress\Snappy.pm C:\perl517\bin\perl.exe C:\perl517\lib\ExtUtils\xsubpp -typemap C:\perl 517\lib\ExtUtils\typemap Snappy.xs > Snappy.xsc && C:\perl517\bin\perl.exe -MEx tUtils::Command -e mv -- Snappy.xsc Snappy.c cl -c -nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -GL -G7 -DWIN32 -D_CONSOLE -DNO_STRICT -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T -MD -Zi -DNDEBUG -O1 -GL -G7 -DVERSION=\"0. 20\" -DXS_VERSION=\"0.20\" "-IC:\perl517\lib\CORE" Snappy.c Snappy.c c:\Documents and Settings\Owner\Desktop\cpan libs\Compress-Snappy-0.20\src\csnap py_decompress.c(302) : warning C4018: '<=' : signed/unsigned mismatch Running Mkbootstrap for Compress::Snappy () C:\perl517\bin\perl.exe -MExtUtils::Command -e chmod -- 644 Snappy.bs C:\perl517\bin\perl.exe -MExtUtils::Mksymlists -e "Mksymlists('NAME'=>\ "Compress::Snappy\", 'DLBASE' => 'Snappy', 'DL_FUNCS' => { }, 'FUNCLIST' => [], 'IMPORTS' => { }, 'DL_VARS' => []);" link -out:blib\arch\auto\Compress\Snappy\Snappy.dll -dll -nologo -nodefa ultlib -debug -opt:ref,icf -ltcg -libpath:"c:\perl517\lib\CORE" -machine:x86 S nappy.obj C:\perl517\lib\CORE\perl517.lib oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut3 2.lib netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib version.lib odbc32.li b odbccp32.lib comctl32.lib msvcrt.lib -def:Snappy.def Creating library blib\arch\auto\Compress\Snappy\Snappy.lib and object blib\ar ch\auto\Compress\Snappy\Snappy.exp Generating code Finished generating code if exist blib\arch\auto\Compress\Snappy\Snappy.dll.manifest mt -nologo - manifest blib\arch\auto\Compress\Snappy\Snappy.dll.manifest -outputresource:blib \arch\auto\Compress\Snappy\Snappy.dll;2 if exist blib\arch\auto\Compress\Snappy\Snappy.dll.manifest del blib\arc h\auto\Compress\Snappy\Snappy.dll.manifest C:\perl517\bin\perl.exe -MExtUtils::Command -e chmod -- 755 blib\arch\au to\Compress\Snappy\Snappy.dll C:\perl517\bin\perl.exe -MExtUtils::Command -e cp -- Snappy.bs blib\arch \auto\Compress\Snappy\Snappy.bs C:\perl517\bin\perl.exe -MExtUtils::Command -e chmod -- 644 blib\arch\au to\Compress\Snappy\Snappy.bs C:\perl517\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/00_compile.t .. ok t/01_snappy.t ... ok All tests successful. Files=2, Tests=1029, 1 wallclock secs ( 0.16 usr + 0.00 sys = 0.16 CPU) Result: PASS C:\Documents and Settings\Owner\Desktop\cpan libs\Compress-Snappy-0.20>
________________________________________________________________________ But ActiveState uses a slightly older C compiler than me, so AS's result will show up at http://code.activestate.com/ppm/Compress-Snappy/ in 1-3 days. It will probably pass uneventfully.
Now Available on AS PPM http://code.activestate.com/ppm/Compress-Snappy/ . Yay!. Everything is done, bug closed.